From c56c59e403c91c4edf9d3be7e350d8821f636ac9 Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Sat, 13 Oct 2018 15:44:23 -0500 Subject: [PATCH 1/2] Mention what you should throw in your UserProvider --- src/Resources/skeleton/security/UserProvider.tpl.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Resources/skeleton/security/UserProvider.tpl.php b/src/Resources/skeleton/security/UserProvider.tpl.php index 46e3cf7ea..e3b8f93b8 100644 --- a/src/Resources/skeleton/security/UserProvider.tpl.php +++ b/src/Resources/skeleton/security/UserProvider.tpl.php @@ -17,6 +17,8 @@ class implements UserProviderInterface * this method. * * @return UserInterface + * + * @throws UsernameNotFoundException if the user is not found */ public function loadUserByUsername($username) { From 803a4fe2d23c3ae03abe504c5aa924262493c111 Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Sat, 13 Oct 2018 15:46:35 -0500 Subject: [PATCH 2/2] Not needed: IDE's are smart enough due to the instanceof check --- src/Resources/skeleton/security/UserProvider.tpl.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Resources/skeleton/security/UserProvider.tpl.php b/src/Resources/skeleton/security/UserProvider.tpl.php index e3b8f93b8..0765b8412 100644 --- a/src/Resources/skeleton/security/UserProvider.tpl.php +++ b/src/Resources/skeleton/security/UserProvider.tpl.php @@ -48,8 +48,6 @@ public function refreshUser(UserInterface $user) throw new UnsupportedUserException(sprintf('Invalid user class "%s".', get_class($user))); } - /* @var $user */ - // Return a User object after making sure its data is "fresh". // Or throw a UsernameNotFoundException if the user no longer exists. throw new \Exception('TODO: fill in refreshUser() inside '.__FILE__);