Implement email verification upon user registration #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
May 12, 2020
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
This looks solid - lets push it across the finish!
src/Resources/skeleton/registration/RegistrationController.tpl.php
Outdated
Show resolved
Hide resolved
jrushlow
commented
May 13, 2020
jrushlow
changed the title
weaverryan
reviewed
May 24, 2020
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Looks awesome - very close!
src/Resources/skeleton/registration/RegistrationController.tpl.php
Outdated
Show resolved
Hide resolved
...xtures/MakeRegistrationFormVerifyEmailFunctionalTest/src/Security/LoginFormAuthenticator.php
Show resolved
Hide resolved
|
|
||
| $form = $crawler->selectButton('Register')->form(); | ||
| $form['registration_form[email]'] = 'jr@rushlow.dev'; | ||
| $form['registration_form[plainPassword]'] = 'makeDockerComingSoon!'; |
|
|
||
| $client->request('GET', $context['signedUriComponents']->getSignedUrl()); | ||
|
|
||
| self::assertTrue(($query->getSingleResult())->isVerified()); |
jrushlow
force-pushed
the
feature/verify-bundle
branch
2 times, most recently
from
8e6b9a8 to
0e2a1b5
Compare
weaverryan
force-pushed
the
feature/verify-bundle
branch
3 times, most recently
from
0ad6575 to
2188851
Compare
weaverryan
force-pushed
the
feature/verify-bundle
branch
from
2188851 to
83447ae
Compare
Member
|
Awesome work Jesse - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for email verification in
make:registration-formby means of the Symfony Cast's Verify Email Bundlecloses #542