Skip to content

Conversation

@mhabibi
Copy link
Contributor

@mhabibi mhabibi commented Sep 19, 2020

Fixes #673

ManyToMany relations:
Before:
ManyToMany-master
After:
ManyToMany-fix

OneToMany relations:
Before:
OneToMany-master
After:
OneToMany-fix

Copy link

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Copy link

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weaverryan
Copy link
Member

This is very cool. Thank you @mhabibi!

@weaverryan weaverryan merged commit b345999 into symfony:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize/simplify generated "remove" method for Doctrine oneToMany relations?

3 participants