fix(make:entity): handle new value if nullable in OneToOne association, close #195

[Kocal]

Hi 👋

This PR is a proposal for #195 for handling the new value (if nullable) in a OneToOne association.

The following code was not valid, it fails at $user->getUserProfile() if we call UserProfile#setUser(null):

class UserProfile
{
    // ...
    public function setUser(?User $user): self
    {
        $this->user = $user;

        // set (or unset) the owning side of the relation if necessary
        $newUserProfile = null === $user ? null : $this;
        if ($user->getUserProfile() !== $newUserProfile) {
            $user->setUserProfile($newUserProfile);
        }

        return $this;
    }
}

The following code takes care of:

• unset the user profile of the previous User ($this->user) if we assign a nullable User
• set the profile to the new user, and prevent an infinite loop with user->getUserProfile() !== $this

class UserProfile 
{
    public function setUser(?User $user): self
    {
        // unset the owning side of the relation if necessary
        if ($user === null && $this->user !== null) {
            $this->user->setUserProfile(null);
        }

        // set the owning side of the relation if necessary
        if ($user !== null && $user->getUserProfile() !== $this) {
            $user->setUserProfile($this);
        }

        $this->user = $user;

        return $this;
    }
}

WDYT? Thanks!

[weaverryan]

Wonderful work! Thanks for this great fix Hugo!