-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anti-404 activation strategy service/class #5
Comments
I do exclude certain 404's where I know the cause, but not generally all 404s. Maybe a cookbook entry would be better to allow people to adjust it to their needs. |
Well how do you typically do this? In general all I see in 404s are a bunch of hacking attempts from scanners trying to exploit phpmyadmin leaks and similar.. I don't know if it's possible to exclude all of those, but I usually just increase the level to CRITICAL just to get rid of the 404s, so I wouldn't mind this "dumb" exclusion mode, it would still be an improvement. |
@Seldaek does the ActivationStrategy of the FingersCrossedHandler could fit your needs for this or do you expect another feature ? If it is enough, it is simply a documentation issue then. |
@stof yes I'm talking about the ActivationStrategy, but no I don't think it's just documentation, providing one configured by default means people get those benefits by default and then can more easily tweak it since it'd just be changing the class of the service or pointing to another service. That's just my point of view anyway. |
👍 for not filling the logs with 404's - or at least providing an easy way to stop it. |
OK this is now possible as: monolog:
handlers:
main:
type: fingers_crossed
action_level: error
handler: nested
excluded_404s:
- ^/foo/ |
Is there a way to make it just exclude all 404s, not just for a specific url? I can't get this to work. |
Excluding this works for me |
I tried that, and it didn't work, so must have been something else wrong. I thought that would do it so I just wanted to check. Thanks :) |
A simple class that avoids triggering the FingersCrossedHandler on 404 errors would be nice. It should still trigger on other 4xx though. This should be made optional I suppose, unless everyone agrees it's a better default. /cc @stof @schmittjoh @fabpot
The text was updated successfully, but these errors were encountered: