Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Symfony <3 #306

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@lyrixx
Copy link
Member

commented Jun 4, 2019

No description provided.

@stof

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

should we make a release with all the existing changes before that ?

Show resolved Hide resolved composer.json Outdated
@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

I don't know. I initially wanted to merge / close as many issue as possible and then make a release.
Before I cleanup this project, the changelog was broken. So making a release without burden could be possible on the very last commit of master f51d377

But IMHO, it's a bit stupid to do a release, and then to continue to merge new things...

I would go for simplicity: do a release after merge of pending PRs (this one, the one about mailer, and a another couples)

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

I agree, let's do one release with everything, including the bumps for the deps.

@lyrixx lyrixx force-pushed the lyrixx:drop-sf-2 branch from 565466e to bca34c1 Jun 11, 2019

@lyrixx lyrixx merged commit bca34c1 into symfony:master Jun 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lyrixx added a commit that referenced this pull request Jun 11, 2019

feature #306 Drop support for Symfony <3 (lyrixx)
This PR was merged into the 3.x-dev branch.

Discussion
----------

Drop support for Symfony <3

Commits
-------

bca34c1 Drop support for Symfony <3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.