Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add InsightOps support #312

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@tristanbes
Copy link
Contributor

commented Aug 8, 2019

closes #311

@tristanbes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Tested on my project: it works 👍@lyrixx

Log_Search

@lyrixx

lyrixx approved these changes Aug 8, 2019

Copy link
Member

left a comment

👍 LGTM

@lyrixx

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Could you add a note in the CHANGELOG?
It will be part of 3.5.0
Thanks

@tristanbes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

yes i'll add this tomorrow.

@tristanbes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

is that ok for you @lyrixx ?

@lyrixx

lyrixx approved these changes Aug 14, 2019

@lyrixx

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thanks for your work on this new feature!

@lyrixx lyrixx merged commit b15f98f into symfony:master Aug 14, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

lyrixx added a commit that referenced this pull request Aug 14, 2019

feature #312 add InsightOps support (tristanbes)
This PR was squashed before being merged into the 3.x-dev branch (closes #312).

Discussion
----------

add InsightOps support

closes #311

Commits
-------

b15f98f add InsightOps support

@tristanbes tristanbes deleted the Yproximite:feature/add-insightops branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.