Do not require raven.dsn when a client_id is specified

[lyrixx]

Right now, I have the following configuration. And as you can see, the raven.dsn
is useless here, are the client_id service is not buildt by the extension
but by myself.

monolog:
    handlers:
        raven:
            type: raven
            # useless, because we set-up a custom client, but we have to...
            dsn:  "%raven.dsn%"
            client_id: sensiolabs.toolkit.monolog.raven_client

So with with patch, we can use:

monolog:
    handlers:
        raven:
            type: raven
            client_id: sensiolabs.toolkit.monolog.raven_client

BTW, I don't know the target branch of this PR.

[stof]

tests are broken

[stof]

And the right target branch is master. Older branches are not maintained (as the master branch supports Symfony 2.3+)

[lyrixx]

And the right target branch is master. Older branches are not maintained (as the master branch supports Symfony 2.3+)

I'm not sure to understand this comment. the target branch is master.

[stof]

I'm not sure to understand this comment. the target branch is master.

It was an answer to your comment BTW, I don't know the target branch of this PR..
It is indeed right currently

[lyrixx]

Oh ;) I forgot that ;) Thanks.

[lyrixx]

I fixed tests.

[stof]

Can you add a new test to cover this behavior (should go near https://github.com/symfony/MonologBundle/blob/1a34465d5f33a2b559dcae7eddd1ef838114994e/Tests/DependencyInjection/MonologExtensionTest.php#L213)

[lyrixx]

Hm, now I understand why I did that before. (remove the if not service-exist).

1. If I keep the code like that (like in master), it's not possible to change the client service because the ContainerBuilder in the empty in this method. So the service will never exist. BUT if you register your bundle after MonologBundle, the definition in your bundle will override the definition created by monolog.
2. If I change the monolog extension, like I did when I opened the PR (I changed the code), This is a very minor BC break, because monolog will no longer create a client definition with the specified service id. Any way, this behavior was wrong and not documented in this way.

So I think, I should update the code to focus on the second point. WDYT?

[lyrixx]

OK, I just implemented the solution N°2

[stof]

Removing the service definition check is indeed the right thing to do. DI extensions cannot check services defined by others. Currently, client_id is unusable.
If you pass a client_id and you don't create the service, you will get an exception later saying the service is missing. It is fine IMO

[lyrixx]

So it's a +1 ?

[stof]

Thanks @lyrixx.