From 4a1153e0ba0c1671a7eac4180d1955349590fd5d Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 21 Nov 2025 10:37:25 +0100 Subject: [PATCH 1/3] make PHPStan happy --- src/PantherTestCaseTrait.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PantherTestCaseTrait.php b/src/PantherTestCaseTrait.php index d1860da5..886d74f9 100644 --- a/src/PantherTestCaseTrait.php +++ b/src/PantherTestCaseTrait.php @@ -203,6 +203,7 @@ protected static function createPantherClient(array $options = [], array $kernel } } + /* @phpstan-ignore-next-line */ if (is_a(self::class, KernelTestCase::class, true)) { static::bootKernel($kernelOptions); // @phpstan-ignore-line } @@ -247,6 +248,7 @@ protected static function createHttpBrowserClient(array $options = [], array $ke self::$httpBrowserClient = new HttpBrowserClient(HttpClient::create($httpClientOptions)); } + /* @phpstan-ignore-next-line */ if (is_a(self::class, KernelTestCase::class, true)) { static::bootKernel($kernelOptions); // @phpstan-ignore-line } From 6b4defc9c6efdb94852565ec4d7c03cf5c3d1cb0 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 21 Nov 2025 10:52:37 +0100 Subject: [PATCH 2/3] fix PHPUnit 10 installation --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ed8bf5aa..0cf3f9f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -190,8 +190,8 @@ jobs: - name: Remove phpunit-bridge dependency (not yet PHPUnit 10+ compliant) run: composer remove --dev symfony/phpunit-bridge - - name: Install latest PHPUnit 11 - run: composer require --dev --prefer-dist 'phpunit/phpunit:>=10' + - name: Install latest PHPUnit 10 + run: composer require --dev --prefer-dist 'phpunit/phpunit:10.5.*' - name: Run tests run: vendor/bin/phpunit --configuration phpunit.xml.dist.10 From 58f099f6de80c3b5cbd3581b5a499813b14fd9a8 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 21 Nov 2025 11:08:40 +0100 Subject: [PATCH 3/3] fix the code style --- .github/workflows/ci.yml | 2 +- tests/ClientTest.php | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0cf3f9f6..2941bb10 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: tools: php-cs-fixer, cs2pr - name: PHP Coding Standards Fixer - run: php-cs-fixer fix --dry-run --format checkstyle | cs2pr + run: php-cs-fixer fix --dry-run --diff phpstan: runs-on: ubuntu-latest diff --git a/tests/ClientTest.php b/tests/ClientTest.php index edda41dd..e65cef1a 100644 --- a/tests/ClientTest.php +++ b/tests/ClientTest.php @@ -282,8 +282,7 @@ public function testExecuteAsyncScript(): void const t = document.querySelector(parentArgs[0]).innerText; callback(t); }, 100, arguments); -JS - , ['.p-1']); +JS, ['.p-1']); $this->assertSame('P1', $innerText); }