From 8bcd51f2c652bd7e70368ae740720daed7ee6f7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Wed, 4 Apr 2018 17:32:36 +0200 Subject: [PATCH] Use Process's array syntax to remove hackish code --- src/ProcessManager/ChromeManager.php | 2 +- src/ProcessManager/WebServerReadinessProbeTrait.php | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/src/ProcessManager/ChromeManager.php b/src/ProcessManager/ChromeManager.php index 3939546a..f59b597f 100644 --- a/src/ProcessManager/ChromeManager.php +++ b/src/ProcessManager/ChromeManager.php @@ -31,7 +31,7 @@ final class ChromeManager implements BrowserManagerInterface public function __construct(?string $chromeDriverBinary = null, ?array $arguments = null) { - $this->process = new Process($this->fixCommand($chromeDriverBinary ?? $this->findChromeDriverBinary()), null, null, null, null); + $this->process = new Process([$chromeDriverBinary ?? $this->findChromeDriverBinary()], null, null, null, null); $this->arguments = $arguments ?? $this->getDefaultArguments(); } diff --git a/src/ProcessManager/WebServerReadinessProbeTrait.php b/src/ProcessManager/WebServerReadinessProbeTrait.php index 205fb3aa..96a07c83 100644 --- a/src/ProcessManager/WebServerReadinessProbeTrait.php +++ b/src/ProcessManager/WebServerReadinessProbeTrait.php @@ -22,18 +22,6 @@ */ trait WebServerReadinessProbeTrait { - /** - * @see http://symfony.com/doc/current/components/process.html#process-signals - */ - private function fixCommand(string $command): string - { - if ('Windows' === PHP_OS_FAMILY || 'Darwin' === PHP_OS_FAMILY) { - return $command; - } - - return "exec $command"; - } - /** * @throws \RuntimeException */