Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP nightly builds #218

Open
nicolas-grekas opened this issue Jan 13, 2020 · 1 comment
Open

Fix PHP nightly builds #218

nicolas-grekas opened this issue Jan 13, 2020 · 1 comment
Labels

Comments

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 13, 2020

Here is a build that fails on PHP8:
https://travis-ci.org/symfony/polyfill/jobs/636310496

Help wanted to fix them!

@stof

This comment has been minimized.

Copy link
Member

@stof stof commented Jan 13, 2020

Most of the failures are related to PHP 8 converting warnings to TypeError for bad arguments.

We need to figure out what to do with them.

Note that if we want to polyfill the behavior exactly both for strict mode and loose mode, we might have to use typehints on the polyfill methods directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.