Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new PHP 7.4 functions #181

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@IonBazan
Copy link
Contributor

commented Jul 22, 2019

This PR adds new PHP 7.4 functions:

Closes #179 and replaces #178

@IonBazan IonBazan changed the title add new PHP 7.4 functions [WIP] add new PHP 7.4 functions Jul 22, 2019

@IonBazan IonBazan force-pushed the IonBazan:php7.4 branch 2 times, most recently from 95d7473 to 02a54ab Jul 22, 2019

src/Php74/Php74.php Outdated Show resolved Hide resolved
src/Php74/Php74.php Outdated Show resolved Hide resolved

@IonBazan IonBazan changed the title [WIP] add new PHP 7.4 functions add new PHP 7.4 functions Jul 22, 2019

@nicolas-grekas
Copy link
Member

left a comment

thanks :)

.travis.yml Outdated Show resolved Hide resolved
src/Php74/Php74.php Outdated Show resolved Hide resolved
src/Php74/Php74.php Outdated Show resolved Hide resolved
src/Php74/Php74.php Outdated Show resolved Hide resolved
src/Php74/composer.json Outdated Show resolved Hide resolved
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Oh, please list the polyfill in the root composer.json and README files too!

src/Php74/Php74.php Outdated Show resolved Hide resolved
src/Php74/Php74.php Outdated Show resolved Hide resolved
@BackEndTea
Copy link
Contributor

left a comment

Looks like this covers the polyfill almost perfectly.

It is probably nicer to add a README.md for this polyfill itself as well, in line with the other polyfills.

tests/Php74/Php74Test.php Outdated Show resolved Hide resolved
tests/Php74/Php74Test.php Outdated Show resolved Hide resolved
tests/Php74/Php74Test.php Outdated Show resolved Hide resolved
src/Php74/Php74.php Show resolved Hide resolved

@IonBazan IonBazan force-pushed the IonBazan:php7.4 branch 2 times, most recently from 909d223 to e039fce Jul 23, 2019


This component provides functions added to PHP 7.4 core:

- [`get_mangled_object_vars`](https://php.net/get_mangled_object_vars)

This comment has been minimized.

Copy link
@IonBazan

IonBazan Jul 23, 2019

Author Contributor

These links are not yet available. They should work after PHP 7.4 is released.

@IonBazan IonBazan force-pushed the IonBazan:php7.4 branch from 6f618c8 to c2b0d8c Jul 23, 2019

@IonBazan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@nicolas-grekas
Copy link
Member

left a comment

almost good to me thanks

README.md Outdated Show resolved Hide resolved
src/Mbstring/Mbstring.php Outdated Show resolved Hide resolved
src/Php74/composer.json Outdated Show resolved Hide resolved

@IonBazan IonBazan force-pushed the IonBazan:php7.4 branch 2 times, most recently from aac8ed5 to cac69ec Jul 24, 2019

@nicolas-grekas nicolas-grekas referenced this pull request Aug 1, 2019

@nicolas-grekas nicolas-grekas force-pushed the IonBazan:php7.4 branch from cac69ec to 141689e Aug 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Thank you @IonBazan.

@nicolas-grekas nicolas-grekas merged commit 141689e into symfony:master Aug 6, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

nicolas-grekas added a commit that referenced this pull request Aug 6, 2019

feature #181 add new PHP 7.4 functions (IonBazan)
This PR was squashed before being merged into the 1.11-dev branch (closes #181).

Discussion
----------

add new PHP 7.4 functions

This PR adds new PHP 7.4 functions:
- [x] `get_mangled_object_vars` (php/php-src@eecd896)
- [x] `mb_str_split` (https://wiki.php.net/rfc/mb_str_split)
- [x] `password_algos` (https://wiki.php.net/rfc/password_registry)

Closes #179 and replaces #178

Commits
-------

141689e add new PHP 7.4 functions

@IonBazan IonBazan deleted the IonBazan:php7.4 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.