Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nighlty builds #217

Merged
merged 1 commit into from Jan 13, 2020
Merged

Fix nighlty builds #217

merged 1 commit into from Jan 13, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 13, 2020

No description provided.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Jan 13, 2020

Tests on PHP8 are not green, but at least they run.

nicolas-grekas added a commit that referenced this pull request Jan 13, 2020
This PR was merged into the 1.13-dev branch.

Discussion
----------

Fix nighlty builds

Commits
-------

d8f2785 Fix nighlty builds
@nicolas-grekas nicolas-grekas merged commit d8f2785 into symfony:master Jan 13, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:nightly-ci branch Jan 13, 2020
@stof

This comment has been minimized.

Copy link
Member

stof commented Jan 13, 2020

Most of the failures are related to PHP 8 converting warnings to TypeError for bad arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.