Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.0] add `str_contains` function #229

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@IonBazan
Copy link
Contributor

IonBazan commented Feb 18, 2020

Copy link
Member

nicolas-grekas left a comment

rebase needed

src/Php80/Php80.php Outdated Show resolved Hide resolved
@IonBazan IonBazan force-pushed the IonBazan:feature/str_contains branch from 6e7d13b to 1457225 Mar 2, 2020
@IonBazan

This comment has been minimized.

Copy link
Contributor Author

IonBazan commented Mar 2, 2020

Rebased 🚀

@IonBazan IonBazan force-pushed the IonBazan:feature/str_contains branch from 1457225 to 69e4465 Mar 2, 2020
src/Php80/Php80.php Outdated Show resolved Hide resolved
@IonBazan IonBazan force-pushed the IonBazan:feature/str_contains branch 2 times, most recently from 874f01a to e7fd1e3 Mar 3, 2020
@IonBazan IonBazan force-pushed the IonBazan:feature/str_contains branch from e7fd1e3 to e80a892 Mar 3, 2020
@xabbuh
xabbuh approved these changes Mar 3, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 3, 2020

Thank you @IonBazan.

@nicolas-grekas nicolas-grekas merged commit 8f1b8e9 into symfony:master Mar 3, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IonBazan IonBazan deleted the IonBazan:feature/str_contains branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.