Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uuid] fix edge cases #241

Merged
merged 1 commit into from Mar 13, 2020
Merged

[Uuid] fix edge cases #241

merged 1 commit into from Mar 13, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 13, 2020

No description provided.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:uuid branch from 6b91b32 to 3a034f8 Mar 13, 2020
@nicolas-grekas nicolas-grekas merged commit c15e237 into symfony:master Mar 13, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:uuid branch Mar 13, 2020
@@ -435,6 +429,15 @@ private static function uuid_parse_as_array($uuid)
);
}

private static function toString($v)

This comment has been minimized.

Copy link
@stof

stof Mar 13, 2020

Member

the name is confusing, as it does not always return a string.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 13, 2020

Author Member

I get that - naming things... Feel free to submit a PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.