Skip to content
Permalink
Branch: master
Commits on Jan 4, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Jan 4, 2020
    * 5.0: (31 commits)
      [HttpClient] NativeHttpClient should not send >1.1 protocol version
      [HttpClient] fix support for non-blocking resource streams
      [Mailer] Make sure you can pass custom headers to Mailgun
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [Security-Guard] fixed 35203 missing name tag in param docblock
      [HttpClient] fix casting responses to PHP streams
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [FrameworkBundle] Fix getUser() phpdoc in AbstractController
      [Mailer] Fix addresses management in Sendgrid API payload
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      Update year in license files
      Update year in license files
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      ...
  2. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 4, 2020
    * 4.4: (26 commits)
      [HttpClient] NativeHttpClient should not send >1.1 protocol version
      [HttpClient] fix support for non-blocking resource streams
      [Mailer] Make sure you can pass custom headers to Mailgun
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [Security-Guard] fixed 35203 missing name tag in param docblock
      [HttpClient] fix casting responses to PHP streams
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [Mailer] Fix addresses management in Sendgrid API payload
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      Update year in license files
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      Update year in license files
      fix version when "anonymous: lazy" was introduced
      ...
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 4, 2020
    * 4.3:
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      Update year in license files
      [HttpClient] fix typo
      [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
      [Routing] Fix i18n routing when the url contains the locale
      Fix BC issue in phpDoc Reflection library
      [Translator] Performance improvement in MessageCatalogue and catalogue operations.
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 4, 2020
    * 3.4:
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      Update year in license files
      [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
      Fix BC issue in phpDoc Reflection library
      [Translator] Performance improvement in MessageCatalogue and catalogue operations.
  5. bug #35134 [PropertyInfo] Fix BC issue in phpDoc Reflection library (…

    nicolas-grekas committed Jan 4, 2020
    …jaapio)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [PropertyInfo] Fix BC issue in phpDoc Reflection library
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #35077
    | License       | MIT
    
    The used phpDocumentor library DocBlockReflection contained a BC break
    that broke this component. The patch was applied in the recently released v4.3.4
    version. But since it is unclear how long this issue existed it is not possible
    to exclude a certain version. Therefor also `\RuntimeExpception` needs to be caught.
    
    The BC break is possibly caused by a change in the TypeResolver library used by the
    DocBlockReflection which is now supporting the more popular generics notation for arrays.
    
    This PR might need some tests but the current test cases are not very clear to me. Instead of patching the code we could also try to ban the broken versions of the used phpdoc libraries, but that would require much more testing, and doesn't really add any value. Especially because the DocBlockReflection and TypeResolver are used by over half a million projects. It would raise more questions than just patching the behavior of the PropertyInfo component.
    
    We are sorry that this issue slipt through our QA pipeline. The linked issue already showed that the issue is now fixed by just doing a `composer update` but it is not very convenient to leave this known issue in symfony.
    
    Commits
    -------
    
    bad07ec557 Fix BC issue in phpDoc Reflection library
You can’t perform that action at this time.