Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Request/Response multiple times #48

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@Nyholm
Copy link
Member

Nyholm commented Aug 8, 2018

By doing this we make sure that we do not loose data.

Im not sure if this is a good idea or even the intention of the bridge. Could someone give me a thumbs up before I start trying to fix the tests?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 11, 2019

LGTM, but let's replace Diactoros by your package instead.

@Nyholm Nyholm force-pushed the Nyholm:multi-convert branch from 0318273 to bbbc4af Mar 11, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Mar 11, 2019

Thank you for the review.

Rebased!

Show resolved Hide resolved .travis.yml Outdated

@Nyholm Nyholm force-pushed the Nyholm:multi-convert branch from 655ea7f to 32a77fc Mar 11, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Mar 11, 2019

Fabbot is happy =)

Just going to fix the test.. Doing it now

@Nyholm Nyholm force-pushed the Nyholm:multi-convert branch from 13041a6 to b3bfdea Mar 11, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Mar 11, 2019

Tests should be green now

@nicolas-grekas nicolas-grekas force-pushed the Nyholm:multi-convert branch from 4e92add to 8564bf7 Mar 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 11, 2019

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit 8564bf7 into symfony:master Mar 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 11, 2019

bug #48 Convert Request/Response multiple times (Nyholm)
This PR was squashed before being merged into the 1.2-dev branch (closes #48).

Discussion
----------

Convert Request/Response multiple times

By doing this we make sure that we do not loose data.

Im not sure if this is a good idea or even the intention of the bridge. Could someone give me a thumbs up before I start trying to fix the tests?

Commits
-------

8564bf7 Convert Request/Response multiple times
@@ -141,7 +141,7 @@ protected function getTemporaryPath()
public function createResponse(ResponseInterface $psrResponse)
{
$cookies = $psrResponse->getHeader('Set-Cookie');
$psrResponse = $psrResponse->withHeader('Set-Cookie', []);

This comment has been minimized.

@jibran

jibran Mar 24, 2019

I think this should be backported to 1.1.1 because it doesn't work with zendframework/zend-diactoros:1.8.6 which requires PHP 7.0

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.