Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MsalsasVotingBundle recipe #416

Merged
2 commits merged into from Jul 11, 2018
Merged

Add MsalsasVotingBundle recipe #416

2 commits merged into from Jul 11, 2018

Conversation

msalsas
Copy link
Contributor

@msalsas msalsas commented Jul 10, 2018

Q A
License MIT

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

negative_vote:
path: /vote-negative/{_locale}/{id}
controller: Msalsas\VotingBundle\Controller\VoteController:voteNegative
methods: POST
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with a newline

"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with a newline

@@ -0,0 +1,8 @@
{
"bundles": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

{
"bundles": {
"Msalsas\\VotingBundle\\MsalsasVotingBundle": ["all"]
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

"bundles": {
"Msalsas\\VotingBundle\\MsalsasVotingBundle": ["all"]
},
"copy-from-recipe": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Good work!

@ghost ghost merged commit 3aded41 into symfony:master Jul 11, 2018
ghost pushed a commit that referenced this pull request Jul 11, 2018
@msalsas msalsas deleted the voting-bundle branch July 11, 2018 13:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants