-
-
Notifications
You must be signed in to change notification settings - Fork 689
Add MsalsasVotingBundle recipe #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
msalsas
commented
Jul 10, 2018
| Q | A |
|---|---|
| License | MIT |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
| negative_vote: | ||
| path: /vote-negative/{_locale}/{id} | ||
| controller: Msalsas\VotingBundle\Controller\VoteController:voteNegative | ||
| methods: POST No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should end with a newline
| "copy-from-recipe": { | ||
| "config/": "%CONFIG_DIR%/" | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should end with a newline
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "bundles": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
| { | ||
| "bundles": { | ||
| "Msalsas\\VotingBundle\\MsalsasVotingBundle": ["all"] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
| "bundles": { | ||
| "Msalsas\\VotingBundle\\MsalsasVotingBundle": ["all"] | ||
| }, | ||
| "copy-from-recipe": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
| }, | ||
| "copy-from-recipe": { | ||
| "config/": "%CONFIG_DIR%/" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Nyholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Good work!