Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for netgen/layouts-core #712

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@emodric
Copy link
Contributor

commented Jul 22, 2019

Q A
License MIT
@symfony-flex-server
Copy link
Contributor

left a comment

Pull request does not pass validation.

@emodric emodric force-pushed the emodric:netgen_layouts branch from 5ed70e1 to 10e1004 Jul 22, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@emodric

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Hi! As with #694, the CI failure is caused by latest version of ocramius/proxy-manager in combination with ignore-platform-reqs option used by Travis.

@emodric emodric force-pushed the emodric:netgen_layouts branch from 10e1004 to 0601947 Jul 24, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@emodric emodric force-pushed the emodric:netgen_layouts branch from 0601947 to b0f2c02 Jul 24, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@emodric emodric force-pushed the emodric:netgen_layouts branch from b0f2c02 to 712f9e9 Jul 24, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@emodric emodric force-pushed the emodric:netgen_layouts branch from 712f9e9 to 91bc553 Jul 24, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@emodric

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Hi, can anyone help get this merged? @nicolas-grekas for example :)

Thanks!

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@emodric can you please embed the patch in #727 to see how it goes on Travis?

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request does not pass validation.

@emodric

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@nicolas-grekas Done. Travis build now passes (yay!), but PR does not validate any more :/

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks for the confirmation, can you please rebase now? We merged the other PR.

@emodric emodric force-pushed the emodric:netgen_layouts branch from a620aee to 24ba350 Aug 9, 2019

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request does not pass validation.

@emodric

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@nicolas-grekas
Copy link
Member

left a comment

(I don't know why the CI validation fails)

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@symfony-flex-server review please

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@symfony-flex-server symfony-flex-server bot merged commit 24ba350 into symfony:master Aug 9, 2019

2 checks passed

continuous-integration/symfony/pr Done
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

symfony-flex-server bot added a commit that referenced this pull request Aug 9, 2019

@emodric

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.