Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Dec 3, 2025

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

Related to symfony/ux#3208

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 3, 2025 23:44
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1498/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1498/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'symfony/ux-translator:^2.32'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/ux-translator

2.8 vs 2.9
diff --git a/symfony/ux-translator/2.8/assets/translator.js b/symfony/ux-translator/2.9/assets/translator.js
index eab7b6c7..28012a65 100644
--- a/symfony/ux-translator/2.8/assets/translator.js
+++ b/symfony/ux-translator/2.9/assets/translator.js
@@ -1,3 +1,4 @@
+import { trans, getLocale, setLocale, setLocaleFallbacks } from '@symfony/ux-translator';
 /*
  * This file is part of the Symfony UX Translator package.
  *
@@ -7,10 +8,6 @@
  * If you use TypeScript, you can rename this file to "translator.ts" to take advantage of types checking.
  */
 
-import { trans, getLocale, setLocale, setLocaleFallbacks } from '@symfony/ux-translator';
-import { localeFallbacks } from '../var/translations/configuration';
-
 setLocaleFallbacks(localeFallbacks);
 
 export { trans };
-export * from '../var/translations';
diff --git a/symfony/ux-translator/2.8/manifest.json b/symfony/ux-translator/2.9/manifest.json
index 3f984fca..a1ac08ba 100644
--- a/symfony/ux-translator/2.8/manifest.json
+++ b/symfony/ux-translator/2.9/manifest.json
@@ -2,8 +2,38 @@
     "bundles": {
         "Symfony\\UX\\Translator\\UxTranslatorBundle": ["all"]
     },
+    "conflict": {
+        "symfony/flex": "<1.20.0 || >=2.0.0,<2.3.0"
+    },
     "copy-from-recipe": {
         "assets/": "assets/",
-        "config/": "%CONFIG_DIR%/"
-    }
+        "config/": "%CONFIG_DIR%/",
+        "var/": "var/"
+    },
+    "add-lines": [
+        {
+            "file": "assets/translator.js",
+            "content": "import { localeFallbacks } from '../var/translations/configuration';",
+            "position": "top",
+            "requires": "symfony/webpack-encore-bundle"
+        },
+        {
+            "file": "assets/translator.js",
+            "content": "import { localeFallbacks } from '@app/translations/configuration';",
+            "position": "top",
+            "requires": "symfony/asset-mapper"
+        },
+        {
+            "file": "assets/translator.js",
+            "content": "export * from '../var/translations';",
+            "position": "bottom",
+            "requires": "symfony/webpack-encore-bundle"
+        },
+        {
+            "file": "assets/translator.js",
+            "content": "export * from '@app/translations';",
+            "position": "bottom",
+            "requires": "symfony/asset-mapper"
+        }
+    ]
 }
diff --git a/symfony/ux-translator/2.9/var/translations/configuration.js b/symfony/ux-translator/2.9/var/translations/configuration.js
new file mode 100644
index 00000000..bea96d63
--- /dev/null
+++ b/symfony/ux-translator/2.9/var/translations/configuration.js
@@ -0,0 +1,3 @@
+export const localeFallbacks = {};
+
+console.log('Run bin/console cache:warmup to generate the translation files.');
diff --git a/symfony/ux-translator/2.9/var/translations/index.js b/symfony/ux-translator/2.9/var/translations/index.js
new file mode 100644
index 00000000..34f7c1ba
--- /dev/null
+++ b/symfony/ux-translator/2.9/var/translations/index.js
@@ -0,0 +1 @@
+console.log('Run bin/console cache:warmup to generate the translation files.');
2.9 vs 2.32
diff --git a/symfony/ux-translator/2.9/assets/translator.js b/symfony/ux-translator/2.32/assets/translator.js
index 28012a65..a0181a08 100644
--- a/symfony/ux-translator/2.9/assets/translator.js
+++ b/symfony/ux-translator/2.32/assets/translator.js
@@ -1,4 +1,6 @@
-import { trans, getLocale, setLocale, setLocaleFallbacks } from '@symfony/ux-translator';
+import { createTranslator } from '@symfony/ux-translator';
+import { messages, localeFallbacks } from '../var/translations/index.js';
+
 /*
  * This file is part of the Symfony UX Translator package.
  *
@@ -8,6 +10,9 @@ import { trans, getLocale, setLocale, setLocaleFallbacks } from '@symfony/ux-tra
  * If you use TypeScript, you can rename this file to "translator.ts" to take advantage of types checking.
  */
 
-setLocaleFallbacks(localeFallbacks);
+const translator = createTranslator({
+    messages,
+    localeFallbacks,
+});
 
-export { trans };
+export const { trans } = translator;
diff --git a/symfony/ux-translator/2.9/manifest.json b/symfony/ux-translator/2.32/manifest.json
index a1ac08ba..5af38680 100644
--- a/symfony/ux-translator/2.9/manifest.json
+++ b/symfony/ux-translator/2.32/manifest.json
@@ -9,31 +9,5 @@
         "assets/": "assets/",
         "config/": "%CONFIG_DIR%/",
         "var/": "var/"
-    },
-    "add-lines": [
-        {
-            "file": "assets/translator.js",
-            "content": "import { localeFallbacks } from '../var/translations/configuration';",
-            "position": "top",
-            "requires": "symfony/webpack-encore-bundle"
-        },
-        {
-            "file": "assets/translator.js",
-            "content": "import { localeFallbacks } from '@app/translations/configuration';",
-            "position": "top",
-            "requires": "symfony/asset-mapper"
-        },
-        {
-            "file": "assets/translator.js",
-            "content": "export * from '../var/translations';",
-            "position": "bottom",
-            "requires": "symfony/webpack-encore-bundle"
-        },
-        {
-            "file": "assets/translator.js",
-            "content": "export * from '@app/translations';",
-            "position": "bottom",
-            "requires": "symfony/asset-mapper"
-        }
-    ]
+    }
 }
diff --git a/symfony/ux-translator/2.9/var/translations/configuration.js b/symfony/ux-translator/2.9/var/translations/configuration.js
deleted file mode 100644
index bea96d63..00000000
--- a/symfony/ux-translator/2.9/var/translations/configuration.js
+++ /dev/null
@@ -1,3 +0,0 @@
-export const localeFallbacks = {};
-
-console.log('Run bin/console cache:warmup to generate the translation files.');

@fabpot fabpot disabled auto-merge December 5, 2025 08:35
@fabpot fabpot merged commit dfa41a0 into symfony:main Dec 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants