New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default phpunit.xml.dist: add filter/whitelist #296

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@lyrixx
Member

lyrixx commented Dec 6, 2017

Q A
License MIT

If we don't do that, phpunit is not able to compute the code coverage.
We get the following error without it:

Error:         Incorrect whitelist config, no code coverage will be generated.
@symfony-flex-server

Pull request passes validation.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 6, 2017

Member

The same change should be applied to the file under phpunit/phpunit

Member

fabpot commented Dec 6, 2017

The same change should be applied to the file under phpunit/phpunit

Fixed default phpunit.xml.dist: add filter/whitelist
If we don't do that, phpunit is not able to compute the code coverage.
We get the following error without it:

```
Error:         Incorrect whitelist config, no code coverage will be generated.
```
@symfony-flex-server

Pull request passes validation.

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Dec 6, 2017

Member

Good catch. It's now fixed.

Member

lyrixx commented Dec 6, 2017

Good catch. It's now fixed.

@fabpot

fabpot approved these changes Dec 6, 2017

@xabbuh

xabbuh approved these changes Dec 7, 2017

@symfony-flex-server symfony-flex-server bot merged commit 04b423b into symfony:master Dec 7, 2017

1 check passed

continuous-integration/symfony/pr Done
Details

symfony-flex-server bot added a commit that referenced this pull request Dec 7, 2017

@lyrixx lyrixx deleted the lyrixx:phpunit branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment