New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweak - if APP_ENV is an empty string, this defaults it back to dev #514

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@weaverryan
Copy link
Member

weaverryan commented Jan 5, 2019

Q A
License MIT

One more tweak after #513

It's an edge-case, but when APP_ENV is set to an empty string

APP_ENV='' php bin/console

Before $_SERVER['APP_ENV'] would be an empty string, after it would be dev.

Or, maybe we decide that the current behavior IS the correct behavior. It's an edge-case either way.

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@chalasr

chalasr approved these changes Jan 5, 2019

@symfony-flex-server symfony-flex-server bot merged commit e5537b6 into symfony:master Jan 5, 2019

1 check passed

continuous-integration/symfony/pr Done
Details

symfony-flex-server bot added a commit that referenced this pull request Jan 5, 2019

@weaverryan weaverryan deleted the weaverryan:dot-env-index-minor-tweak branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment