New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vague description of autoconfigure #515 #517

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Nek-
Copy link

Nek- commented Jan 8, 2019

Q A
License MIT

See #515 for details.

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

Nek- added a commit to Nek-/symfony-docs that referenced this pull request Jan 8, 2019

@@ -9,7 +9,7 @@ services:
# default configuration for services in *this* file
_defaults:
autowire: true # Automatically injects dependencies in your services.
autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
autoconfigure: true # Automatically adds corresponding tags to your services depending on interfaces they implement.

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Jan 8, 2019

Member

it does not only tag but can call methods
and it looks at all parent classes, not only interfaces.
I'm not sure we can be less vague while being accurate ;)

This comment has been minimized.

@B-Galati

B-Galati Jan 8, 2019

Contributor

I think we could add a parenthesis like so:

Automatically registers your services as commands, event subscribers, etc. (By adding tags, method calls, etc.) when class type is supported.

This comment has been minimized.

@Pierstoval

Pierstoval Jan 8, 2019

Contributor

What about Automatically adds useful options to services that extend certain classes and add a link to https://symfony.com/blog/new-in-symfony-3-3-service-autoconfiguration ?

@Nek-

This comment has been minimized.

Copy link

Nek- commented Jan 8, 2019

Would this be more acceptable?

- Automatically registers your services as commands, event subscribers, etc.
+ Automatically tag your services as commands, event subscribers, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment