Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getenv() not working with .env.local.php #540

Merged

Conversation

Projects
None yet
4 participants
@MisatoTremor
Copy link
Contributor

MisatoTremor commented Mar 1, 2019

Q A
License MIT

When dumping the env using Flex 1.2 dump-env the getenv function does no longer work for these variables.
This is a quick fix just like it is done in DotEnv::populate, but might need further review.

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@Nyholm

Nyholm approved these changes Apr 6, 2019

Copy link
Member

Nyholm left a comment

I agree with this.

Currently we have the situation that something is working in local development where DotEnv is installed. But when you deploy and use composer dump-env prod then it is broken.

#eu-fossa

@lyrixx

lyrixx approved these changes Apr 6, 2019

@symfony-flex-server symfony-flex-server bot merged commit ea8af67 into symfony:master Apr 6, 2019

1 check passed

continuous-integration/symfony/pr Done
Details

symfony-flex-server bot added a commit that referenced this pull request Apr 6, 2019

@MisatoTremor MisatoTremor deleted the MisatoTremor:fix_getenv_with_dump branch Apr 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Apr 10, 2019

Sorry but this should not have been merged: putenv is not thread safe and calling it breaks app on ZTS.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Apr 10, 2019

Reverted in #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.