Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for http-client #548

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 11, 2019

Q A
License MIT

Needs symfony/symfony#30419

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:http-client branch from f3d053b to 4ab121b Mar 12, 2019

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:http-client branch from 4ab121b to 26194e4 Mar 12, 2019

@symfony-flex-server symfony-flex-server bot requested a deployment to staging Mar 12, 2019 Abandoned

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@@ -0,0 +1,4 @@
framework:

This comment has been minimized.

@OskarStark

OskarStark Mar 12, 2019

Contributor

In other recipes we only create config files if the bring additional value and don't only expose default variables and this looks only like the defaults 🤔

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Mar 12, 2019

Author Member

the http_client service needs to be explicitly enabled, this does it
but maybe we should enable it conditionally in the fwb integration!
Is that what your mean? Doing a class_exists check there and remove the recipe?

This comment has been minimized.

@Pierstoval

Pierstoval Mar 12, 2019

Contributor

If the HttpClient package is not required by any of the skeleton's dependencies, it means it certainly can be activated automatically by the fwb if the package is installed, this would probably save a recipe for it 😄

This comment has been minimized.

@OskarStark

OskarStark Mar 13, 2019

Contributor

Yes I thought about it. Does it makes sense?

This comment has been minimized.

@weaverryan

weaverryan Mar 13, 2019

Member

I just added a comment on the PR that we should auto-activate it if the component is installed.

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:http-client branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.