Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSR7 and PSR17 aliases #550

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Nyholm
Copy link
Member

Nyholm commented Mar 12, 2019

Q A
License MIT

This is a follow up on #546. I forgot to add some aliases.

@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

I thought about this also, but wouldn't one expect to get the bridge when doing "composer require psr7"?

Show resolved Hide resolved nyholm/psr7/1.0/manifest.json Outdated
@symfony-flex-server
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Mar 12, 2019

I thought about this also, but wouldn't one expect to get the bridge when doing "composer require psr7"?

Actually no =)
I would not expect the bridge when I just want a PSR7 implementation..

Suggestion: I modify this to alias "PSR-17", then create a pack for alias "PSR-7". That pack would include the bridge and nyholm/psr7.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 12, 2019

That pack would include the bridge and nyholm/psr7

LGTM - we'd also need sensio-framework-extra-bundle in that pack so that everything works seamlessly, isn't it?

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Mar 12, 2019

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.