Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project dir to framework bundle #564

Merged
1 commit merged into from Apr 3, 2019
Merged

Add project dir to framework bundle #564

1 commit merged into from Apr 3, 2019

Conversation

tdutrion
Copy link
Contributor

@tdutrion tdutrion commented Apr 3, 2019

Q A
License MIT

References #555 and symfony/symfony#30651

This defines the project directory without looking for the composer.json.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 27f7c9c into symfony:master Apr 3, 2019
ghost pushed a commit that referenced this pull request Apr 3, 2019
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Apr 4, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

Update project directory method override

This follows up symfony/recipes#564 (not yet merged), and updates the documentation according to the actual code provided in the recipe.

Commits
-------

f48dd00 Update project directory method override
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants