Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Load packages configuration after services configuration #585

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@lyrixx
Copy link
Member

commented May 7, 2019

Some people tends to declare some services in /config/package/foobar.yaml.
More over, some recipies does that too

But with the default configuration, services are overriden in
services.yaml (auto-discovery) and so the services does not work.

This patch made the packages directory prioritary overy the services
files

Q A
License MIT

I found this "issue" by helping someone on slack.

[FrameworkBundle] Load packages configuration after services configur…
…ation

Some people tends to declare some services in `/config/package/foobar.yaml`.
More over, some recipies does that [too](https://github.com/symfony/recipes/tree/master/sensiolabs/security-checker/4.0/config/packages)

But with the default configuration, services are overriden in
`services.yaml` (auto-discovery) and so the services does not work.

This patch made the packages directory prioritary overy the services
files
@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@fabpot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

I think that the current configuration is the right one. services.yaml is your file, so it should override the "default" configuration coming from packages/

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 7, 2019

I agree with Fabien: packages configures something in vendor/ services.yaml is for src/
The linked recipe does follow this rule too.

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

I agree with you too.

I just wanted your feedback :)

@lyrixx lyrixx closed this May 7, 2019

@lyrixx lyrixx deleted the lyrixx:packages-after-services branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.