Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mailer DSNs for 4.4 #644

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@fabpot
Copy link
Member

commented Sep 3, 2019

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...
@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@fabpot

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

This pull request updates the DSNs and also removes the intermediary env vars for following reasons:

  • Having env vars embedded into other ones does not work well with Dotenv;
  • Having less env vars is "better"
  • Having the user/pass/key/id embedded into the DSN makes it easier to understand that they need to be URL encoded.
@fabpot
Copy link
Member Author

left a comment

merge now

symfony-flex-server bot added a commit that referenced this pull request Sep 3, 2019

@symfony-flex-server symfony-flex-server bot merged commit 683da10 into master Sep 3, 2019

1 check passed

continuous-integration/symfony/pr Done
Details
@@ -0,0 +1,5 @@
{
"env": {
"#1": "MAILER_DSN=sendgrid://KEY@default"

This comment has been minimized.

Copy link
@bocharsky-bw

bocharsky-bw Sep 4, 2019

Contributor

Shouldn't it be MAILER_DSN=sendgrid+smtp://KEY@default to be consistent with 4.3 recipe?

This comment has been minimized.

Copy link
@fabpot

fabpot Sep 4, 2019

Author Member

sendgrid is the equivalent of sendgrid+smtp. The default is now automatically the "best" transport possible.

This comment has been minimized.

Copy link
@bocharsky-bw

bocharsky-bw Sep 4, 2019

Contributor

I got it, thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.