Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.js #683

Merged
merged 1 commit into from Jan 10, 2020
Merged

Update app.js #683

merged 1 commit into from Jan 10, 2020

Conversation

@noniagriconomie
Copy link
Contributor

noniagriconomie commented Nov 19, 2019

Q A
License MIT
Doc issue/PR none

I think it is better, isn't it?
Was just testing this bundle with a bare demo project

Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@stof

This comment has been minimized.

Copy link
Member

stof commented Nov 19, 2019

Using ES imports is indeed better (some webpack optimizations apply only for ES imports).

For jQuery, it won't change much though, given that jQuery does not ship a module build. But it might have an impact for other packages.

@noniagriconomie

This comment has been minimized.

Copy link
Contributor Author

noniagriconomie commented Nov 19, 2019

@stof thx for this explanation
i was also looking at the symfony cast where this code was written :)
(https://symfonycasts.com/screencast/webpack-encore)

@fabpot
fabpot approved these changes Jan 10, 2020
symfony-flex-server bot added a commit that referenced this pull request Jan 10, 2020
@symfony-flex-server symfony-flex-server bot merged commit 5fe4ccf into symfony:master Jan 10, 2020
1 check passed
1 check passed
continuous-integration/symfony/pr Done
Details
@noniagriconomie noniagriconomie deleted the noniagriconomie:patch-1 branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.