Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Router] Add recipe for 5.1 router context config #722

Open
wants to merge 1 commit into
base: master
from

Conversation

@ogizanagi
Copy link
Member

ogizanagi commented Jan 10, 2020

Q A
License MIT
Doc issue/PR N/A

Follows symfony/symfony#35281

Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.


# Replace these node to configure the "request context" to use to generate URLs
# in non-HTTP contexts, such as CLI commands.
# See https://symfony.com/doc/current/routing.html#generating-urls-in-commands

This comment has been minimized.

Copy link
@ogizanagi

ogizanagi Jan 10, 2020

Author Member

This doc is not up-to-date yet, but there is probably no reason to move it elsewhere.

@ogizanagi ogizanagi force-pushed the ogizanagi:router-context-config branch from 5e3a6e3 to e2f96bd Jan 10, 2020
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

symfony/routing/5.1/config/packages/routing.yaml Outdated Show resolved Hide resolved
#context:
# host: localhost
# scheme: http
# base_url: null

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 11, 2020

Member

shouldn't this be a single setting: http://lcalhost/path/?

This comment has been minimized.

Copy link
@ogizanagi

ogizanagi Jan 13, 2020

Author Member

That's not how the router context works right now. Do you think it's worth adding such support?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 13, 2020

Member

I think yes, that's how it should work to me.

This comment has been minimized.

Copy link
@ogizanagi

ogizanagi Jan 13, 2020

Author Member

@benji07: interested?

@ogizanagi ogizanagi force-pushed the ogizanagi:router-context-config branch from e2f96bd to 008f275 Jan 13, 2020
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.