Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at the Kernel for annotations #735

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 2, 2020

Q A
License MIT
Doc issue/PR -

Since this will be allowed by symfony/symfony#35560 and allows writting single-file apps in the kernel, for microapps.

Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.

@yceruto
yceruto approved these changes Feb 2, 2020
@fabpot
fabpot approved these changes Feb 3, 2020
symfony-flex-server bot added a commit that referenced this pull request Feb 3, 2020
@symfony-flex-server symfony-flex-server bot merged commit 49370eb into symfony:master Feb 3, 2020
1 check passed
1 check passed
continuous-integration/symfony/pr Done
Details
fabpot added a commit to symfony/symfony that referenced this pull request Feb 3, 2020
…ontrollers (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpKernel] allow using public aliases to reference controllers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR allows referencing a controller with an alias when needed. The use case I'm targetting is using `@Route` annotations on methods of the `App\Kernel` and have them work. This PR allows it.

Sidekick of symfony/recipes#735

Commits
-------

94bc1f7 [HttpKernel] allow using public aliases to reference controllers
symfony-splitter pushed a commit to symfony/http-kernel that referenced this pull request Feb 3, 2020
…ontrollers (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpKernel] allow using public aliases to reference controllers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR allows referencing a controller with an alias when needed. The use case I'm targetting is using `@Route` annotations on methods of the `App\Kernel` and have them work. This PR allows it.

Sidekick of symfony/recipes#735

Commits
-------

94bc1f7d3b [HttpKernel] allow using public aliases to reference controllers
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Feb 3, 2020
…ontrollers (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpKernel] allow using public aliases to reference controllers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR allows referencing a controller with an alias when needed. The use case I'm targetting is using `@Route` annotations on methods of the `App\Kernel` and have them work. This PR allows it.

Sidekick of symfony/recipes#735

Commits
-------

94bc1f7d3b [HttpKernel] allow using public aliases to reference controllers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.