Skip to content
Permalink
Branch: master
Commits on Mar 16, 2020
Commits on Mar 12, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Mar 12, 2020
    * 5.0: (36 commits)
      Add test for tagged iterator with numeric index
      Fix container lint command when a synthetic service is used in combination with the expression language
      Fix Travis script
      [Validator][Range] Fix typos
      [SecurityBundle] Minor fix in LDAP config tree builder
      [HttpClient] fix requests to hosts that idn_to_ascii() cannot handle
      Revert "minor #35559 [FrameworkBundle] remove mention of the old Controller class (nicolas-grekas)"
      [FrameworkBundle] remove redundant PHPDoc in console Descriptor and subclass
      [Mime] remove phpdoc mentioning Utf8AddressEncoder
      Add missing phpdoc
      Remove int return type from FlattenException::getCode
      [Yaml] fix dumping strings containing CRs
      [DI] Fix XmlFileLoader bad error message
      [Form] Handle false as empty value on expanded choices
      [Messenger] Add ext-redis min version req to tests
      Tweak message
      improve PlaintextPasswordEncoder docBlock summary
      [Validator] Add two missing translations for the Arabic (ar) locale
      Use some PHP 5.4 constants unconditionally
      Add new packages on the link script
      ...
  2. Merge branch '4.4' into 5.0

    nicolas-grekas committed Mar 12, 2020
    * 4.4: (34 commits)
      Add test for tagged iterator with numeric index
      Fix container lint command when a synthetic service is used in combination with the expression language
      [Validator][Range] Fix typos
      [SecurityBundle] Minor fix in LDAP config tree builder
      [HttpClient] fix requests to hosts that idn_to_ascii() cannot handle
      [FrameworkBundle] remove redundant PHPDoc in console Descriptor and subclass
      [Mime] remove phpdoc mentioning Utf8AddressEncoder
      Add missing phpdoc
      Remove int return type from FlattenException::getCode
      [Yaml] fix dumping strings containing CRs
      [DI] Fix XmlFileLoader bad error message
      [Form] Handle false as empty value on expanded choices
      [Messenger] Add ext-redis min version req to tests
      Tweak message
      improve PlaintextPasswordEncoder docBlock summary
      [Validator] Add two missing translations for the Arabic (ar) locale
      Use some PHP 5.4 constants unconditionally
      Add new packages on the link script
      [DI] fix dumping errored definitions
      [DI] ignore extra tags added by autoconfiguration in PriorityTaggedServiceTrait
      ...
Commits on Mar 2, 2020
  1. minor #35926 [Routing] Fix some wrong localized routes tests (fancyweb)

    nicolas-grekas committed Mar 2, 2020
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Routing] Fix some wrong localized routes tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    ~~Since symfony/symfony#35855, the `_locale` path param is directly substituted so those tests are not valid cases anymore. Instead, the path directly contain the right locale.~~ Actually, the compilation is done after, so instead we need to set the new requirement in all tests to reflect the "reality".
    
    symfony/symfony#35855 also causes a BC break on one case:
    ```php
    $compiledUrlGenerator->generate('foo.fr', ['_locale' => 'en']))
    ```
    
    Previously, the generated route would be the `/en/fourchette`. Now that the locale is hardcoded in the route path, it will always be `/fr/fourchette`. I changed `foo` to relevant words because it is easier to understand like that.
    
    Commits
    -------
    
    99ae55ff1a [Routing] Fix some wrong localized routes tests
You can’t perform that action at this time.