Making it possible to add a "default" import for shorter controller name #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
added a commit
that referenced
this pull request
May 31, 2022
…age or the user (weaverryan) This PR was merged into the main branch. Discussion ---------- Allowing the controller name to be overridden by the package or the user This is needed for live components, where the controller name needs to be simply `live`... else it will be super annoying to use :). Allowing the user to also override the controller name... isn't really needed... but if the user does this, I think they know they are on their own. This COULD actually replace #69... as a package could add, for example, `name: 'symfony/ux-typed'` to change the name to a shorter version. Commits ------- d8f6d5b Allowing the controller name to be overridden by the package or the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the UX controller names have the form
symfony/ux-typed/typed(well, technicallysymfony--ux-typed--typed, butstimulus_controller()normalizes for you).Anyways, most UX components only ship with 1 controller... and
symfony/ux-typed/typedseems unnecessarily long. This PR allows for a package to define a controller calleddefaultin its package.json - e.g. right here: https://github.com/symfony/ux/blob/09c9effcc2582d4de0907c9e12c35afa313433ae/src/Typed/Resources/assets/package.json#L8When this happens, the final package name would be just the package name:
symfony/ux-typedCheers!