Skip to content
Permalink
Branch: master
Commits on Oct 8, 2019
Commits on Oct 7, 2019
  1. minor #33816 [String] renamed core classes to Byte/CodePoint/UnicodeS…

    nicolas-grekas committed Oct 7, 2019
    …tring (nicolas-grekas)
    
    This PR was merged into the 5.0-dev branch.
    
    Discussion
    ----------
    
    [String] renamed core classes to Byte/CodePoint/UnicodeString
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    In #33553 there have been discussions about the naming of the classes - eg. "what's a grapheme", "why `Utf8String`", "lowercase on binary is weird", etc.
    
    What about these names? Would they get your votes *vs* the current ones?
    - `BinaryString` -> `ByteString`
    - `Utf8String` -> `CodePointString`
    - `GraphemeString` -> `UnicodeString`
    
    Commits
    -------
    
    63c105d406 [String] renamed core classes to Byte/CodePoint/UnicodeString
Commits on Oct 4, 2019
Commits on Oct 2, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Oct 2, 2019
    * 4.4:
      fix merge
  2. bug #33807 [String] fix toAscii() (nicolas-grekas)

    nicolas-grekas committed Oct 2, 2019
    This PR was merged into the 5.0-dev branch.
    
    Discussion
    ----------
    
    [String] fix toAscii()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? |
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    46a23f87d9 [String] fix toAscii()
You can’t perform that action at this time.