Browse files

feature #4433 Completely re-reading the controller chapter (weaverryan)

This PR was merged into the 2.3 branch.


Completely re-reading the controller chapter

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.3+
| Fixed ticket | n/a

Hi guys!

This follows #4427, but only for the controller chapter (I will open separate PR's for `from_flat_php_to_symfony2`, `routing`, and `templating`).

This is more than just updating for the best practices. This is about face-lifting these important chapters after several years of us as a community realizing what's more important and what's less important. More notes:

- I removed some information about using the `defaults` to pass additional information to your controller from this chapter. This is too early and we have this now:

- I removed `ContainerAware` information. This is not the right spot... and maybe nothing is. I don't see much use-case for this - it seems like you'd either extend the base Controller or register your controller as a service.

- I kind of want to remove or move the forwarding stuff. I can't find a real use-case for doing a forward from one controller to another. It adds a lot of overhead and I don't see any situation for it.



903f52c Fixing build error
ceb7b94 Big update based on feedback from xabbuh and WouterJ
6ef10db Moving forwarding section all the way to the bottom
0754efc Completely re-reading the controller chapter
  • Loading branch information...
weaverryan committed Nov 25, 2014
2 parents 5db8386 + 903f52c commit 135aae6caa9508b12a2960579ea0af4dacd3e479
Showing with 234 additions and 248 deletions.
  1. +228 −248 book/controller.rst
  2. +2 −0 book/service_container.rst
  3. +2 −0 book/templating.rst
  4. +2 −0 components/http_foundation/introduction.rst
Oops, something went wrong.

0 comments on commit 135aae6

Please sign in to comment.