From 995b8ac36a32b0a9c59b55ab94cbc70f82699a55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?cl=C3=A9ment=20larrieu?= Date: Fri, 15 Mar 2024 11:35:34 +0100 Subject: [PATCH 1/5] doc: added a disambiguation on what the identifier is Users could be confused seeing getUserId() and returning a user Id instead of the identifier defined in the app, such as an email. --- security/access_token.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/security/access_token.rst b/security/access_token.rst index 81a3a9cdabe..c5a202249b1 100644 --- a/security/access_token.rst +++ b/security/access_token.rst @@ -97,6 +97,7 @@ This handler must implement } // and return a UserBadge object containing the user identifier from the found token + // the user identifier being an email, a username and not necessarily an Id return new UserBadge($accessToken->getUserId()); } } From c802af32e9393aaaf408c0f875d29e6e66ba569f Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Mon, 25 Mar 2024 16:17:05 +0100 Subject: [PATCH 2/5] Minor reword --- security/access_token.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/access_token.rst b/security/access_token.rst index c5a202249b1..df02f3da6bc 100644 --- a/security/access_token.rst +++ b/security/access_token.rst @@ -97,7 +97,8 @@ This handler must implement } // and return a UserBadge object containing the user identifier from the found token - // the user identifier being an email, a username and not necessarily an Id + // (this is the same identifier used in Security configuration; it can be an email, + // a UUUID, a username, a database ID, etc.) return new UserBadge($accessToken->getUserId()); } } From 8733549a31d01dd5fb5cd8fac5b05940a68075f1 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Mon, 25 Mar 2024 16:25:05 +0100 Subject: [PATCH 3/5] [AssetMapper] Adding updater to comparison table --- frontend.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/frontend.rst b/frontend.rst index 519fe69e350..2314c9f5556 100644 --- a/frontend.rst +++ b/frontend.rst @@ -37,6 +37,7 @@ Supports TypeScript :ref:`yes ` yes Removes comments from JavaScript no yes Removes comments from CSS no no Versioned assets always optional +Can update 3rd party packages yes yes :ref:`[3] ` ================================ ================================== ========== .. _ux-note-1: @@ -46,6 +47,14 @@ need to use their native tools for pre-compilation. Also, some features (like Vue single-file components) cannot be compiled down to pure JavaScript that can be executed by a browser. +.. _ux-note-2: + +**[2]** There are some `PostCSS`_ plugins available to remove comments from CSS files. + +.. _ux-note-3: + +**[3]** Update checkers are available for NPM, e.g. `npm-check`. + .. _frontend-asset-mapper: AssetMapper (Recommended) From 0a6719096d20359d044d1fd964d0b319637de2c7 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Mon, 25 Mar 2024 16:26:18 +0100 Subject: [PATCH 4/5] Tweak --- frontend.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend.rst b/frontend.rst index 2314c9f5556..2c4a9671236 100644 --- a/frontend.rst +++ b/frontend.rst @@ -37,7 +37,7 @@ Supports TypeScript :ref:`yes ` yes Removes comments from JavaScript no yes Removes comments from CSS no no Versioned assets always optional -Can update 3rd party packages yes yes :ref:`[3] ` +Can update 3rd party packages yes no :ref:`[3] ` ================================ ================================== ========== .. _ux-note-1: @@ -53,7 +53,7 @@ be executed by a browser. .. _ux-note-3: -**[3]** Update checkers are available for NPM, e.g. `npm-check`. +**[3]** If you use ``npm``, there are update checkers available (e.g. ``npm-check``). .. _frontend-asset-mapper: From f65137144162b98b52767dd1bc05ecd6361ec5c9 Mon Sep 17 00:00:00 2001 From: Thomas Landauer Date: Mon, 25 Mar 2024 18:15:16 +0100 Subject: [PATCH 5/5] [AssetMapper] Removing orphaned footnote [2] Page: https://symfony.com/doc/6.4/frontend.html --- frontend.rst | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/frontend.rst b/frontend.rst index 2c4a9671236..6b7aa6f5048 100644 --- a/frontend.rst +++ b/frontend.rst @@ -37,7 +37,7 @@ Supports TypeScript :ref:`yes ` yes Removes comments from JavaScript no yes Removes comments from CSS no no Versioned assets always optional -Can update 3rd party packages yes no :ref:`[3] ` +Can update 3rd party packages yes no :ref:`[2] ` ================================ ================================== ========== .. _ux-note-1: @@ -49,11 +49,7 @@ be executed by a browser. .. _ux-note-2: -**[2]** There are some `PostCSS`_ plugins available to remove comments from CSS files. - -.. _ux-note-3: - -**[3]** If you use ``npm``, there are update checkers available (e.g. ``npm-check``). +**[2]** If you use ``npm``, there are update checkers available (e.g. ``npm-check``). .. _frontend-asset-mapper: