Skip to content
Permalink
Branch: master
Commits on Jan 21, 2020
  1. Merge branch '5.0'

    javiereguiluz committed Jan 21, 2020
    * 5.0:
      Remove usages of transChoice() method for Symfony 5.0
  2. Merge branch '4.4' into 5.0

    javiereguiluz committed Jan 21, 2020
    * 4.4:
      Remove usages of transChoice() method for Symfony 5.0
  3. minor #12957 Remove usages of transChoice() method for Symfony 5.0 (k…

    javiereguiluz committed Jan 21, 2020
    …ane-menicou)
    
    This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.4 branch instead (closes #12957).
    
    Discussion
    ----------
    
    Remove usages of transChoice() method for Symfony 5.0
    
    The `transChoice()` method and the `transChoice` Twig filter [were removed in Symfony 5.0](https://github.com/symfony/symfony/blob/master/UPGRADE-5.0.md#frameworkbundle)
    
    **Notes for reviewers:** I'm not too sure about the new `Pluralized Translations` section, I couldn't find any other information about it in the docs so maybe it's relevant? I'm not sure if there's a better place to put it (maybe: `components/translation.rst`), or if it's even needed?
    
    Commits
    -------
    
    73376df Remove usages of transChoice() method for Symfony 5.0
  4. Remove usages of transChoice() method for Symfony 5.0

    kane-menicou authored and javiereguiluz committed Jan 18, 2020
  5. Merge branch '5.0'

    javiereguiluz committed Jan 21, 2020
    * 5.0:
      tweaking the password upgrading functionality
  6. Merge branch '4.4' into 5.0

    javiereguiluz committed Jan 21, 2020
    * 4.4:
      tweaking the password upgrading functionality
  7. Minor tweak

    javiereguiluz committed Jan 21, 2020
  8. minor #12960 tweaking the password upgrading functionality (weaverryan)

    javiereguiluz committed Jan 21, 2020
    This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #12960).
    
    Discussion
    ----------
    
    tweaking the password upgrading functionality
    
    Hi!
    
    Minor tweaks to the password upgrading section as I read through it - it was already quite good.
    
    Commits
    -------
    
    94fc0b4 tweaking the password upgrading functionality
  9. tweaking the password upgrading functionality

    weaverryan authored and javiereguiluz committed Jan 18, 2020
  10. Merge branch '5.0'

    javiereguiluz committed Jan 21, 2020
    * 5.0:
      Fix invalid variable name
  11. Merge branch '4.4' into 5.0

    javiereguiluz committed Jan 21, 2020
    * 4.4:
      Fix invalid variable name
  12. Merge branch '4.3' into 4.4

    javiereguiluz committed Jan 21, 2020
    * 4.3:
      Reversed the variable name fix
      Fix invalid variable name
  13. Reversed the variable name fix

    javiereguiluz committed Jan 21, 2020
  14. minor #12966 [Workflow] Fix invalid variable name (piotrantosik)

    javiereguiluz committed Jan 21, 2020
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Workflow] Fix invalid variable name
    
    Commits
    -------
    
    4ac71d1 Fix invalid variable name
Commits on Jan 20, 2020
  1. Fix invalid variable name

    piotrantosik committed Jan 20, 2020
Commits on Jan 17, 2020
  1. minor #12952 [Yaml] Documented the yaml-lint binary (javiereguiluz)

    javiereguiluz committed Jan 17, 2020
    This PR was squashed before being merged into the master branch (closes #12952).
    
    Discussion
    ----------
    
    [Yaml] Documented the yaml-lint binary
    
    Fixes #12935.
    
    Commits
    -------
    
    b6dcce0 [Yaml] Documented the yaml-lint binary
  2. [Yaml] Documented the yaml-lint binary

    javiereguiluz committed Jan 16, 2020
  3. Merge branch '5.0'

    javiereguiluz committed Jan 17, 2020
    * 5.0:
      Fixed an RST syntax issue
  4. Merge branch '4.4' into 5.0

    javiereguiluz committed Jan 17, 2020
    * 4.4:
      Fixed an RST syntax issue
  5. Merge branch '4.3' into 4.4

    javiereguiluz committed Jan 17, 2020
    * 4.3:
      Fixed an RST syntax issue
  6. Fixed an RST syntax issue

    javiereguiluz committed Jan 17, 2020
  7. minor #12948 [FrameworkBundle] Mention that setting router.utf8 is no…

    javiereguiluz committed Jan 17, 2020
    …w mandatory (javiereguiluz)
    
    This PR was squashed before being merged into the master branch (closes #12948).
    
    Discussion
    ----------
    
    [FrameworkBundle] Mention that setting router.utf8 is now mandatory
    
    This fixes #12936.
    
    Commits
    -------
    
    51cf7f0 [FrameworkBundle] Mention that setting router.utf8 is now mandatory
  8. Merge branch '5.0'

    OskarStark committed Jan 17, 2020
    * 5.0:
      Fix Typo
  9. Merge branch '4.4' into 5.0

    OskarStark committed Jan 17, 2020
    * 4.4:
      Fix Typo
  10. Merge branch '4.3' into 4.4

    OskarStark committed Jan 17, 2020
    * 4.3:
      Fix Typo
  11. Merge branch '3.4' into 4.3

    OskarStark committed Jan 17, 2020
    * 3.4:
      Fix Typo
  12. bug #12954 Fix Typo (belghiti)

    OskarStark committed Jan 17, 2020
    This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes #12954).
    
    Discussion
    ----------
    
    Fix Typo
    
    Fix a typo in line 12 is build => is built
    
    <!--
    
    If your pull request fixes a BUG, use the oldest maintained branch that contains
    the bug (see https://symfony.com/roadmap for the list of maintained branches).
    
    If your pull request documents a NEW FEATURE, use the same Symfony branch where
    the feature was introduced (and `master` for features of unreleased versions).
    
    -->
    
    Commits
    -------
    
    ef087ab Fix Typo
  13. Fix Typo

    belghiti authored and OskarStark committed Jan 16, 2020
    Fix a typo in line 12 is build => is built
Commits on Jan 16, 2020
  1. Merge branch '5.0'

    OskarStark committed Jan 16, 2020
    * 5.0:
      minor
      Move method and class
      Use the get method instead of using the array
  2. Merge branch '4.4' into 5.0

    OskarStark committed Jan 16, 2020
    * 4.4:
      minor
      Move method and class
      Use the get method instead of using the array
  3. minor

    OskarStark committed Jan 16, 2020
  4. Merge branch '4.3' into 4.4

    OskarStark committed Jan 16, 2020
    * 4.3:
      Move method and class
      Use the get method instead of using the array
  5. Merge branch '3.4' into 4.3

    OskarStark committed Jan 16, 2020
    * 3.4:
      Move method and class
      Use the get method instead of using the array
  6. minor #12945 Move method and class (OskarStark)

    OskarStark committed Jan 16, 2020
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Move method and class
    
    It reads more natural to me.
    
    I would check the following branches if you agree and in this case we could add a Doctor rule.
    
    Cheers
    
    Commits
    -------
    
    8bffa06 Move method and class
Older
You can’t perform that action at this time.