Permalink
Commits on May 20, 2017
  1. Merge branch '3.4'

    * 3.4: (40 commits)
      Adding an article to explain the 3.3 changes, and how to upgrade
      updating instance
      Avoid backticks in shell scripts
      Update optional_dependencies.rst
      Fix xml blocks
      pass only strings to loadUserByUsername()
      Fix Authenticator Class (getCredentials) example
      Documented addAnnotatedClassesToCompile() and the use of class patterns
      Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods.
      [#7205] minor tweak
      Simplified the use of transChoice()
      [#7875] minor tweaks
      Minor fix
      Minor changes
      Properly show all events and describe guard events
      [#7891] remove not needed sentence
      [#7773] fix line length
      Add helpful remarks on custom DataCollector
      Remove use of deprecated security.exception_listener.class parameter
      Update resources.rst
      ...
    weaverryan committed May 20, 2017
  2. feature #7921 Adding an article to explain the 3.3 changes, and how t…

    …o upgrade (weaverryan)
    
    This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #7921).
    
    Discussion
    ----------
    
    Adding an article to explain the 3.3 changes, and how to upgrade
    
    This article is aimed at existing Symfony users: I want to explain how the new DI features work and the "why" behind them a bit more (and at a deeper technical level).
    
    I'll also write a blog post on symfony.com pointing to this article.
    
    Review - related to how things are explained, clarity, technical points, etc - is quite needed! :)
    
    Thanks!
    
    Commits
    -------
    
    8bbecf2 Adding an article to explain the 3.3 changes, and how to upgrade
    weaverryan committed May 20, 2017
  3. Merge branch '3.2' into 3.3

    * 3.2: (39 commits)
      updating instance
      Avoid backticks in shell scripts
      Update optional_dependencies.rst
      Fix xml blocks
      pass only strings to loadUserByUsername()
      Fix Authenticator Class (getCredentials) example
      Documented addAnnotatedClassesToCompile() and the use of class patterns
      Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods.
      [#7205] minor tweak
      Simplified the use of transChoice()
      [#7875] minor tweaks
      Minor fix
      Minor changes
      Properly show all events and describe guard events
      [#7891] remove not needed sentence
      [#7773] fix line length
      Add helpful remarks on custom DataCollector
      Remove use of deprecated security.exception_listener.class parameter
      Update resources.rst
      Fix incoherent ut8mb4 collation in Doctrine setup
      ...
    weaverryan committed May 20, 2017
  4. Merge branch '2.8' into 3.2

    * 2.8:
      updating instance
      Avoid backticks in shell scripts
    weaverryan committed May 20, 2017
  5. Merge branch '2.7' into 2.8

    * 2.7:
      updating instance
      Avoid backticks in shell scripts
    weaverryan committed May 20, 2017
  6. Merge remote-tracking branch 'origin/2.7' into 2.7

    * origin/2.7: (51 commits)
      Avoid backticks in shell scripts
      Update optional_dependencies.rst
      Fix xml blocks
      [#7875] minor tweaks
      Minor fix
      Minor changes
      [#7773] fix line length
      Add helpful remarks on custom DataCollector
      Remove use of deprecated security.exception_listener.class parameter
      Update resources.rst
      Fix incoherent ut8mb4 collation in Doctrine setup
      Fix decorating service definition
      fix empty XML element
      [#7873] add missing toctree entries
      Reworded the introduction of the contributing docs
      [#7844] add XML and PHP config examples
      Property access
      [HttpFoundation] Fix clearstatcache first arg
      Explain how to provide a stack trace
      fix remaining setDefinition() call
      ...
    weaverryan committed May 20, 2017
  7. updating instance

    weaverryan committed May 20, 2017
Commits on May 18, 2017
  1. minor #7918 Avoid backticks in shell scripts (greg0ire)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Avoid backticks in shell scripts
    
    - $() should be preferred : http://mywiki.wooledge.org/BashFAQ/082
    - it makes it easier to discuss these lines on Slack (or any
    markdown-compatible thing).
    
    Commits
    -------
    
    f1e7cf0 Avoid backticks in shell scripts
    xabbuh committed May 18, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8: (24 commits)
      Update optional_dependencies.rst
      Fix xml blocks
      pass only strings to loadUserByUsername()
      Fix Authenticator Class (getCredentials) example
      Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods.
      [#7875] minor tweaks
      Minor fix
      Minor changes
      [#7773] fix line length
      Add helpful remarks on custom DataCollector
      Remove use of deprecated security.exception_listener.class parameter
      Update resources.rst
      Fix incoherent ut8mb4 collation in Doctrine setup
      Fix decorating service definition
      fix empty XML element
      [#7873] add missing toctree entries
      Reworded the introduction of the contributing docs
      [HttpFoundation] Fix clearstatcache first arg
      Explain how to provide a stack trace
      Add link to the Slack support channel
      ...
    xabbuh committed May 18, 2017
  3. Avoid backticks in shell scripts

    - $() should be preferred : http://mywiki.wooledge.org/BashFAQ/082
    - it makes it easier to discuss these lines on Slack (or any
    markdown-compatible thing).
    greg0ire committed May 18, 2017
  4. Merge branch '3.4'

    * 3.4:
      Updating more types, and basically rewriting the alias article
      More updating for types
      typo
    weaverryan committed May 18, 2017
  5. feature #7916 More updates for DI types philosophy (weaverryan)

    This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #7916).
    
    Discussion
    ----------
    
    More updates for DI types philosophy
    
    Hi guys!
    
    This is another big (sorry) PR for updating things for using type-hinting for injection. I only have a few directories remaining to review!
    
    FYI, the following directories I'm not planning on reviewing, at least not right away (so, these are up for grabs!)
    - best_practices
    - bundles
    - components
    - console
    - create_framework
    - reference
    
    Thanks!
    
    Commits
    -------
    
    6d01473 Updating more types, and basically rewriting the alias article
    1f7d4b5 More updating for types
    weaverryan committed May 18, 2017
  6. More updating for types

    weaverryan committed May 16, 2017
  7. Merge branch '2.7' into 2.8

    * 2.7: (21 commits)
      Update optional_dependencies.rst
      Fix xml blocks
      [#7875] minor tweaks
      Minor fix
      Minor changes
      [#7773] fix line length
      Add helpful remarks on custom DataCollector
      Remove use of deprecated security.exception_listener.class parameter
      Update resources.rst
      Fix incoherent ut8mb4 collation in Doctrine setup
      Fix decorating service definition
      fix empty XML element
      [#7873] add missing toctree entries
      Reworded the introduction of the contributing docs
      [HttpFoundation] Fix clearstatcache first arg
      Explain how to provide a stack trace
      Add link to the Slack support channel
      Mentioned FOSRestBundle's content negotiation
      Used the article example consistently in the example
      Update formats.rst
      ...
    xabbuh committed May 18, 2017
  8. minor #7911 [DependencyInjection] Fix decorating service definition (…

    …michaelperrin)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fix decorating service definition
    
    There is an error, particularly on the YAML definition where the `decoration_inner_name` option is not defined on the correct service. It should be defined on the decorating service, and not on the decorated service.
    
    The XML definition was correct, but was lacking some properties to make things clearer.
    
    There PHP definition was not using the correct name of the decorated service.
    
    I have fixed the indentation as well on the YAML configuration.
    
    Commits
    -------
    
    dabf122 Fix decorating service definition
    xabbuh committed May 18, 2017
  9. minor #7912 pass only strings to loadUserByUsername() (xabbuh)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    pass only strings to loadUserByUsername()
    
    This completes #7065 as since the change made there the `token` key can refer to `null`.
    
    Commits
    -------
    
    a47ed88 pass only strings to loadUserByUsername()
    xabbuh committed May 18, 2017
  10. minor #7910 Update optional_dependencies.rst (javihgil)

    This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7910).
    
    Discussion
    ----------
    
    Update optional_dependencies.rst
    
    Update injected service name according to the previous service definition "app.mailer" instead of "my_mailer" in XML and PHP blocks.
    
    Commits
    -------
    
    eb36653 Update optional_dependencies.rst
    xabbuh committed May 18, 2017
  11. Update optional_dependencies.rst

    javihgil committed with xabbuh May 16, 2017
  12. minor #7915 Fix xml blocks (GuilhemN)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix xml blocks
    
    Commits
    -------
    
    2bf7529 Fix xml blocks
    xabbuh committed May 18, 2017
  13. Revert "minor #7914 Fix a typo (GuilhemN)"

    This reverts commit 2d50550.
    xabbuh committed May 18, 2017
  14. minor #7914 Fix a typo (GuilhemN)

    This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #7914).
    
    Discussion
    ----------
    
    Fix a typo
    
    Commits
    -------
    
    8adf5ec typo
    xabbuh committed May 18, 2017
  15. typo

    GuilhemN committed with xabbuh May 17, 2017
  16. minor #7914 Fix a typo (GuilhemN)

    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    Fix a typo
    
    Commits
    -------
    
    f5e9e6b typo
    javiereguiluz committed May 18, 2017
Commits on May 17, 2017
  1. Fix xml blocks

    GuilhemN committed May 17, 2017
  2. minor #6951 [Routing] Add a note for invokable controllers (chalasr)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Routing] Add a note for invokable controllers
    
    Since this feature can help to avoid defining controllers as services or writing `Controller::__invoke` when it's not needed, I think we should document it.
    
    Commits
    -------
    
    0b046b3 [Routing] Add a note for refering invokable controllers
    xabbuh committed May 17, 2017
  3. minor #7065 Fix Authenticator Class (getCredentials) example (thtroyer)

    This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #7065).
    
    Discussion
    ----------
    
    Fix Authenticator Class (getCredentials) example
    
    The current wording surrounding the getCredentials is misleading.  Returning null does stop authentication, but it causes authentication to be successful.  The example implies that X-AUTH-TOKEN is required and should be correct.  For this behavior, either an AuthenticationException should be thrown or the credential variables should be initialized as empty and passed on to getUser().
    
    Commits
    -------
    
    52d56f4 Fix Authenticator Class (getCredentials) example
    xabbuh committed May 17, 2017
  4. minor #7193 Documented addAnnotatedClassesToCompile() and the use of …

    …class patterns (javiereguiluz)
    
    This PR was squashed before being merged into the 3.2 branch (closes #7193).
    
    Discussion
    ----------
    
    Documented addAnnotatedClassesToCompile() and the use of class patterns
    
    This fixes #7175.
    
    Commits
    -------
    
    e2a67cd Documented addAnnotatedClassesToCompile() and the use of class patterns
    xabbuh committed May 17, 2017
  5. minor #7280 [Security][Guard] Added a picture for Guard Authenticator…

    … (a-ast)
    
    This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #7280).
    
    Discussion
    ----------
    
    [Security][Guard] Added a picture for Guard Authenticator
    
    This illustration shows how GuardAuthenticationListener calls methods of Guard Authenticator.
    
    Commits
    -------
    
    ed0e6da Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods.
    xabbuh committed May 17, 2017
  6. Added the picture that shows how GuardAuthenticationListener calls Au…

    …thentication Guard methods.
    a-ast committed with xabbuh Dec 20, 2016
  7. [#7205] minor tweak

    xabbuh committed May 17, 2017