Permalink
Commits on Nov 5, 2018
  1. Merge branch '4.1'

    weaverryan committed Nov 5, 2018
    * 4.1:
      web/ -> public/ after merge
      adding a small entry about ajax code splitting
      fixing build errors
      Documenting copyFiles() and a few small things
      finishing read-through
      more work on encore
      Adding docs for runtime.js and fixed a few other things
      documenting the new split chunks and Twig helper functions for Encore
  2. Merge branch '3.4' into 4.1

    weaverryan committed Nov 5, 2018
    * 3.4:
      adding a small entry about ajax code splitting
      fixing build errors
      Documenting copyFiles() and a few small things
      finishing read-through
      more work on encore
      Adding docs for runtime.js and fixed a few other things
      documenting the new split chunks and Twig helper functions for Encore
  3. feature #10322 [WCM] Encore updates for Webpack 4 (weaverryan)

    weaverryan committed Nov 5, 2018
    This PR was squashed before being merged into the 3.4 branch (closes #10322).
    
    Discussion
    ----------
    
    [WCM] Encore updates for Webpack 4
    
    Phew! The next (unreleased) version of Webpack Encore (will be 0.21.0) that supports Webpack 4 will contain a few minor changes, that have major implications on the documentation. Ultimately, I think the experience will be easier for users :). The 3 big changes are:
    
    1) In all cases, people should use the new WebpackEncoreBundle and its 2 new Twig functions - `encore_entry_script_tags()` and `encore_entry_link_tags()` to render their `script` and `link` tags.
    
    2) In earlier versions, an extra `manifest.js` file was output when using `createdSharedEntry()`. But now, a new `runtime.js` file is *always* output. But, because of the `encore_entry_script_tags()` shortcut... that's just rendered for you automatically.
    
    3) `createSharedEntry()` is no longer hipster ;). This is from changes in Webpack. A newer, and better "split chunks" feature replaces it... which (other than changing how existing users think), is much simpler. Basically, the user does nothing... except call `encore_entry_script_tags()`. But, when this feature is enabled, the final `.js` and `.css` files may be split into multiple files. And so, the `encore_entry_script_tags()` (and also the link version) may render *multiple* script tags. This all happens automatically.
    
    TODO: Wait for the bundle to be tagged, then test the new recipe (symfony/recipes#458) and code through some of the docs to catch any mistakes (due to so many changes).
    
    **Merging into 4.1 TODOS**
    * update `web/` to `public/`
    
    Cheers!
    
    Commits
    -------
    
    12ca7d9 adding a small entry about ajax code splitting
    165432f fixing build errors
    bf649ab Documenting copyFiles() and a few small things
    6833bb6 finishing read-through
    c2b36a2 more work on encore
    53f9ffe Adding docs for runtime.js and fixed a few other things
    62f322e documenting the new split chunks and Twig helper functions for Encore
Commits on Nov 2, 2018
  1. fixing build errors

    weaverryan committed Nov 2, 2018
  2. finishing read-through

    weaverryan committed Nov 2, 2018
  3. more work on encore

    weaverryan committed Nov 2, 2018
Commits on Oct 26, 2018
Commits on Oct 24, 2018
Commits on Oct 18, 2018
  1. Fixing bad logic, caused by merge originally

    weaverryan committed Oct 18, 2018
  2. Merge branch '4.1'

    weaverryan committed Oct 18, 2018
    * 4.1:
      removing old reference
      Fixing missing link
      Tweaks based on feedback
      Reword
      Teak
      Fix some bugs, added missing note, removed dead code and revamping code
      Some punctuation stuff
      Many changes thanks for GREAT feedback from various people
      Overhauling the security section
      Update conditions.rst
      Update conditions.rst
      Update conditions.rst
      Update conditions.rst
  3. feature #10423 [Security] Huge Overhaul of all security (weaverryan)

    weaverryan committed Oct 18, 2018
    This PR was squashed before being merged into the 4.1 branch (closes #10423).
    
    Discussion
    ----------
    
    [Security] Huge Overhaul of all security
    
    Hi guys!
    
    I would *warmly* appreciate review, though, I realize that this is another *huge* PR. Apologies - but the security section really needed it.
    
    Here are some important notes:
    
    * I've made the changes to 4.1, following in a newer policy we've been adopting to only apply changes (with the exception of strict bug fixes) to the current-released branch or higher.
    
    * This uses some new features from the upcoming release of MakerBundle. Specifically `make:user` and the enhanced `make:auth` that is capable of generating the entire login form setup. These have simplified & shortened parts of the docs.
    
    * I've made Guard the preferred authentication mechanism. We show it first... and then mention the other, built-in providers, like `form_login`, etc.
    
    * The `simple_preauth` and `simple_form` are not currently documented at all after this change. I believe we should discuss deprecating them.
    
    Cheers!
    
    Commits
    -------
    
    ed3dd65 removing old reference
    7d01771 Fixing missing link
    3e63a6c Tweaks based on feedback
    0c8d7c0 Many changes thanks for GREAT feedback from various people
    066794f Overhauling the security section
  4. removing old reference

    weaverryan committed Oct 18, 2018
  5. Fixing missing link

    weaverryan committed Oct 18, 2018
  6. Tweaks based on feedback

    weaverryan committed Oct 18, 2018
Commits on Oct 13, 2018
Commits on Oct 8, 2018
  1. minor #10362 [Encore] unify the name of app file (gregurco)

    weaverryan committed Oct 8, 2018
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Encore] unify the name of app file
    
    Hello.
    I found 2 problems related to app file in WebPack config:
    1) Relative path was not used in one place (`'assets/js/app.js'` instead of `'./assets/js/app.js'`) - what caused an error in my case.
    2) In some cases there was `main.js` instead of `app.js`, but everywhere in text I found references only to `app.js` file. I guess it should be unified.
    
    Commits
    -------
    
    9c65752 [Encore] unify the name of app file
Commits on Aug 28, 2018
  1. Merge branch '4.1'

    weaverryan committed Aug 28, 2018
    * 4.1:
      {% if label is not same as(false) and required %}
      minor language tweak
      Update service_container.rst
      Fix wrong exception used in custom authentication provider example
      [Console] Replace useless usage of ContainerAwareCommand
      Shorten ternary operator
      Fix wrong usage in custom authenticator checking if password is invalid
      [Process] Fix typo in Process object initialization
      update hardcoded 5.1 version link
      Explain dump server usage outside of Symfony
      Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
      Update bugs.rst
      [#10200] remove trailing spaces
      action_method is missing $task variable
      [#10177] fix markup
      Clarifying when you need to or don't need to install the server bundle
      Fix bad link
      Update setup.rst
      Also requiring annotations so they can be used
  2. Merge branch '3.4' into 4.1

    weaverryan committed Aug 28, 2018
    * 3.4:
      {% if label is not same as(false) and required %}
      Update service_container.rst
      Shorten ternary operator
      Fix wrong usage in custom authenticator checking if password is invalid
      [Process] Fix typo in Process object initialization
      update hardcoded 5.1 version link
      Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
      Update bugs.rst
      [#10200] remove trailing spaces
      action_method is missing $task variable
      Fix bad link
  3. Merge branch '2.8' into 3.4

    weaverryan committed Aug 28, 2018
    * 2.8:
      {% if label is not same as(false) and required %}
      Shorten ternary operator
      Fix wrong usage in custom authenticator checking if password is invalid
      update hardcoded 5.1 version link
      Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
      Update bugs.rst
      [#10200] remove trailing spaces
      action_method is missing $task variable
      Fix bad link
  4. bug #10208 {% if label is not same as(false) and required %} (gonzakpo)

    weaverryan committed Aug 28, 2018
    This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10208).
    
    Discussion
    ----------
    
    {% if label is not same as(false) and required %}
    
    {% if label is not same as(false) and required %}
    
    <!--
    
    If your pull request fixes a BUG, use the oldest maintained branch that contains
    the bug (see https://symfony.com/roadmap for the list of maintained branches).
    
    If your pull request documents a NEW FEATURE, use the same Symfony branch where
    the feature was introduced (and `master` for features of unreleased versions).
    
    -->
    
    Commits
    -------
    
    d6f024a {% if label is not same as(false) and required %}
  5. feature #10204 Explain dump server usage outside of Symfony (skunkbad…

    weaverryan committed Aug 28, 2018
    …, weaverryan)
    
    This PR was merged into the 4.1 branch.
    
    Discussion
    ----------
    
    Explain dump server usage outside of Symfony
    
    Took hours for me to figure out how to use the dump server outside of Symfony, because there is no mention that it can be done, and one must use the ServerDumper class to make it work.
    
    <!--
    
    If your pull request fixes a BUG, use the oldest maintained branch that contains
    the bug (see https://symfony.com/roadmap for the list of maintained branches).
    
    If your pull request documents a NEW FEATURE, use the same Symfony branch where
    the feature was introduced (and `master` for features of unreleased versions).
    
    -->
    
    Commits
    -------
    
    d360452 minor language tweak
    eac5218 Explain dump server usage outside of Symfony
  6. minor language tweak

    weaverryan committed Aug 28, 2018
  7. feature #10203 [Finder] Add undocumented method in finder.rst (alavie…

    weaverryan committed Aug 28, 2018
    …ille)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Finder] Add undocumented method in finder.rst
    
    Add undocumented methods in finder.rst :
    
    `sortByAccessedTime`
    `sortByChangedTime`
    `sortByModifiedTime`
    
    Commits
    -------
    
    8cb53ca Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
  8. bug #10199 Fix bad link (tleneveu)

    weaverryan committed Aug 28, 2018
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Fix bad link
    
    The link  http://localhost:4321/hello/?name=Fabien is not valid because it does not match the route /hello but the route /hello/ and therefore returns a 404 error.
    
    It must be written this way:
    
    http://localhost:4321/hello?name=Fabien
    
    <!--
    
    If your pull request fixes a BUG, use the oldest maintained branch that contains
    the bug (see https://symfony.com/roadmap for the list of maintained branches).
    
    If your pull request documents a NEW FEATURE, use the same Symfony branch where
    the feature was introduced (and `master` for features of unreleased versions).
    
    -->
    
    Commits
    -------
    
    1761050 Fix bad link
Commits on Aug 18, 2018
  1. Merge branch '4.1'

    weaverryan committed Aug 18, 2018
    * 4.1:
      minor fixes
      Shorter array syntax for declaring numbers variable
      Twig is included with Symfony. No need to have the user run composer
      The `profiler-pack` is included in the composer package. It can be a bit confusing to the user with the extra stuff showing on the screen.
      Move the controller tip out of the annotation routes.
  2. bug #10177 Page Creation Small Changes (ahinkle, weaverryan)

    weaverryan committed Aug 18, 2018
    This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #10177).
    
    Discussion
    ----------
    
    Page Creation Small Changes
    
    This PR includes changes to the page creation page for the user to easily understand the breakdown and removes unnecessary areas.
    
    - Move the Controller tip to the example controller area instead of the annotation route. The hint currently drops unexpectedly to the end user after a routes discussion.
    
    - The `profiler-pack` is already included with the Symfony package. Removed composer installation area. Additionally, users may be confused why there is more than one route when it declares "You should see one route" -- added a note on debugging routes.
    
    - Twig is automatically included with Symfony. No need to direct the user to require and install it with composer.
    
    - Shorter, more elegant array syntax on the `render()` example.
    
    Commits
    -------
    
    14ca439 minor fixes
    cecebdc Shorter array syntax for declaring numbers variable
    9d33d42 Twig is included with Symfony. No need to have the user run composer
    2bc5bed The `profiler-pack` is included in the composer package. It can be a bit confusing to the user with the extra stuff showing on the screen.
    56b64c0 Move the controller tip out of the annotation routes.
  3. minor fixes

    weaverryan committed Aug 18, 2018
  4. Merge branch '4.1'

    weaverryan committed Aug 18, 2018
    * 4.1:
      added a space before "=" in code
      fix the markup
      Changing to absolute url, as requested
      Updated link to Event Listeners page
      Update form_customization.rst
      Revert "Fix typo on which YAML values must not be quoted"
      Fix typo (shard -> shared)
      Fix typo on which YAML values must not be quoted
      Change all occurrences of Controller to AbstractController
      fix `HandlerLocator`'s use statement
  5. Merge branch '3.4' into 4.1

    weaverryan committed Aug 18, 2018
    * 3.4:
      added a space before "=" in code
      fix the markup
      Changing to absolute url, as requested
      Updated link to Event Listeners page
      Revert "Fix typo on which YAML values must not be quoted"
      Fix typo (shard -> shared)
      Fix typo on which YAML values must not be quoted
  6. Merge branch '2.8' into 3.4

    weaverryan committed Aug 18, 2018
    * 2.8:
      fix the markup
      Changing to absolute url, as requested
      Updated link to Event Listeners page
      Revert "Fix typo on which YAML values must not be quoted"
      Fix typo on which YAML values must not be quoted