Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Introduce a locale-aware Slugger in the String component #12404

Closed
nicolas-grekas opened this issue Oct 2, 2019 · 1 comment

Comments

@nicolas-grekas
Copy link
Member

commented Oct 2, 2019

Q A
Feature PR symfony/symfony#33768
PR author(s) @tgalopin
Merged in 5.0-dev
@javiereguiluz javiereguiluz added the String label Oct 9, 2019
@OskarStark OskarStark added this to the 5.0 milestone Oct 11, 2019
javiereguiluz added a commit that referenced this issue Oct 14, 2019
This PR was squashed before being merged into the master branch (closes #12440).

Discussion
----------

Documented the String component

Fixes #12376 and #12404. This is an early WIP to test if this is correct.

@nicolas-grekas the full API is very long because there are a ton of methods ... so I thought about grouping them by "topic". Would you agree with that?

Thanks!

Commits
-------

9d08de4 Documented the String component
@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Oct 14, 2019

Fixed by #12440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.