Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Facelift] Forms (book/forms.rst) #2384

Closed
weaverryan opened this Issue Mar 30, 2013 · 2 comments

Comments

Projects
None yet
3 participants
Member

weaverryan commented Mar 30, 2013

This ticket is about re-reading this document and giving it a facelift. No matter who you are, you have a role to play in this.

How this works:

If you read this document and find some changes, you can either comment here or (even better) create a pull request. After various people have reviewed this chapter, we'll close this issue.

What to do

Well, that depends on who you are :)

If you're newer to Symfony

Read the entry and code along with it.
a) Are there inaccuracies - code that doesn't work?
b) Are there parts that just don't understand very well?
c) Are there details that aren't explained enough?
d) Is there language that's confusing?
e) Did you fall asleep while reading it? If so, good morning! Why was it so boring?
f) Are there inconsistencies between sections?

If you know Symfony pretty darn well (or want a challenge)!

a) Are there inconsistencies between sections?
b) Do you spot anything that can be done better?
c) Are we following best practices?
d) Are there sections that are too advanced or details that should be moved into a new section to keep this readable?
e) Should some details here belong somewhere else? Like in the component documentation?
f) Are there places where we can link to other areas in the documentation to help the learner cross reference?

Member

wouterj commented Mar 30, 2013

This component changed a lot since version 2.0. We need to make sure we don't use old deprecated (or even removed) code. Testing the code on all branches is really important for this one.

Contributor

mickaelandrieu commented Apr 6, 2013

For the 2.2, it's good (for me).

Maybe should we insist on the creation of Form Type as a Service ? It's well documented but it's hard to understand that a form is a field :) and I think the article on the cookbook should be on the main documentation

(i.e this one : http://symfony.com/doc/current/cookbook/form/create_custom_field_type.html )

@wouterj wouterj closed this Dec 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment