New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Added doc for ControllerTrait::isFormValid #10852

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@lyrixx
Copy link
Member

lyrixx commented Jan 7, 2019

Show resolved Hide resolved best_practices/forms.rst Outdated

@lyrixx lyrixx force-pushed the lyrixx:form-is-valid branch 2 times, most recently from c61ddbd to de93030 Jan 7, 2019

Show resolved Hide resolved best_practices/forms.rst Outdated
Show resolved Hide resolved best_practices/forms.rst Outdated
Show resolved Hide resolved best_practices/forms.rst
Show resolved Hide resolved forms.rst

@lyrixx lyrixx force-pushed the lyrixx:form-is-valid branch from de93030 to a5c9592 Jan 8, 2019

@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Jan 8, 2019

@OskarStark Thanks for the review. I updated the PR

@lyrixx lyrixx force-pushed the lyrixx:form-is-valid branch from a5c9592 to 7415ef9 Jan 8, 2019

Show resolved Hide resolved best_practices/forms.rst Outdated
Show resolved Hide resolved forms.rst Outdated

@lyrixx lyrixx force-pushed the lyrixx:form-is-valid branch from 7415ef9 to 66dd325 Jan 9, 2019

@xabbuh xabbuh added this to the 4.3 milestone Jan 9, 2019

@xabbuh

xabbuh approved these changes Jan 9, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 11, 2019

let's close here as the feature is going to be reverted (see symfony/symfony#29813)

@xabbuh xabbuh closed this Jan 11, 2019

@lyrixx lyrixx deleted the lyrixx:form-is-valid branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment