Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Add doc Watch Options configuration #11398

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@Kocal
Copy link
Contributor

Kocal commented Apr 10, 2019

Hi,

This PR add a new page that shows how to easily configure watching options with Encore:

Encore.configureWatchOptions(watchOptions => {
  watchOptions.poll = 250;
});

I've also reworked the Advanced Config page to remove the old way to configure watch options.

Thanks!

Kocal added some commits Apr 10, 2019

@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Apr 11, 2019

@Kocal thanks a lot for this and all the other Encore related contributions. We merged it in the 3.4 branch and we changed it a bit. We don't want article that are too short, because they break the reading flow of a normal article into multiple small articles.

That's why we've removed the 14-line long frontend/encore/watch-options.rst article and moved its contents back into the main article about advanced Encore features. I hope you understand it. Thanks.

@Kocal

This comment has been minimized.

Copy link
Contributor Author

Kocal commented Apr 11, 2019

Oops I forgot to change branch to 3.4. 😅

Yes don't worry, that's totally normal. :)

@Kocal Kocal deleted the Kocal:encore/watch-options branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.