Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing retrieving metadata examples #11473

Open
wants to merge 4 commits into
base: master
from

Conversation

@carherco
Copy link

commented Apr 23, 2019

There was no example about retrieving place metadata from the controller. I tried to fixed it as well as the example of retrieving transition metadata. Don't know wether the code I propose is correct. It would need a revision from anybody who knows how it works.

Fixing retrieving metadata examples
There was no example about retrieving place metadata from the controller. I tried to fixed it as well as the example of retrieving transition metadata. Don't know wether the code I propose is correct. It would need a revision from anybody who knows how it works.
workflow.rst Outdated Show resolved Hide resolved
Name of PHP variables in camel case
The array key comes from configuration in line 528
workflow.rst Outdated Show resolved Hide resolved
workflow.rst Outdated Show resolved Hide resolved

@OskarStark OskarStark added the Workflow label Apr 25, 2019

@noniagriconomie

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@carherco can you check if your Pr is still relevant on 4.3 doc now ?
Thx

@carherco

This comment has been minimized.

Copy link
Author

commented May 21, 2019

@noniagriconomie MetadataStoreInterface (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/Metadata/MetadataStoreInterface.php) has not changed in 4.3 so this docs should be the same as in 4.2 version.

Update workflow.rst
default value of priority and max_num_of_words are now numbers
@noniagriconomie

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

hello @carherco , i meant rebase the PR and see if your addition is still relevant as it is or if it needs rewrite :)

@carherco

This comment has been minimized.

Copy link
Author

commented May 22, 2019

Sorry, I don't manage well rebase, merge, pull request...

I merged branch 'master' into patch-1, repair conflicts and rewrite some docs.

Then I realised that you asked me to do it not with 'master' but with branch 4.3. I don't know how, but I did a pull request: #11591

I don't know if i am doing things well or not. I hope you are able to manage with the mess I created. Sorry.

@OskarStark OskarStark changed the base branch from master to 4.3 May 23, 2019

@OskarStark OskarStark changed the base branch from 4.3 to master May 23, 2019

@lyrixx
lyrixx approved these changes Sep 10, 2019
Copy link
Member

left a comment

Perfect 👍
Thanks

@OskarStark OskarStark added this to the 4.3 milestone Sep 11, 2019

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@carherco thanks for this contribution and we're really sorry it took us so long to merge it. We're trying to merge in the 4.3 branch but we're facing too many issues. Could you please rebase this to the 4.3 branch? If you can't ... we'll create a new pull request for 4.3 with your changes (or, if you want, you can create a new pull request against 4.3 with these changes so you get credit for the contribution). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.