Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend including the package name in messages #11522

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
5 participants
@greg0ire
Copy link
Contributor

commented May 3, 2019

Version numbers, but they make more sense when you know the package
name. Most times, you will be able to figure it out from some FQCN, but
this should make things easier for everyone.

cc @nicolas-grekas who told me about this best practice

I'm unsure about whether this is the best branch for that kind of (pedantic ?) change

Recommend including the package name in messages
Version numbers, but they make more sense when you know the package
name. Most times, you will be able to figure it out from some FQCN, but
this should make things easier for everyone.

@javiereguiluz javiereguiluz added this to the 3.4 milestone May 6, 2019

@javiereguiluz javiereguiluz merged commit d2cfba7 into symfony:3.4 May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details

javiereguiluz added a commit that referenced this pull request May 6, 2019

minor #11522 Recommend including the package name in messages (greg0ire)
This PR was merged into the 3.4 branch.

Discussion
----------

Recommend including the package name in messages

Version numbers, but they make more sense when you know the package
name. Most times, you will be able to figure it out from some FQCN, but
this should make things easier for everyone.

cc @nicolas-grekas who told me about this best practice

I'm unsure about whether this is the best branch for that kind of (pedantic ?) change

Commits
-------

d2cfba7 Recommend including the package name in messages
@javiereguiluz

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Grégoire, thanks for improving this! While merging I replaced foo-org/bar-lib by vendor-name/package-name because I think it's easier to understand.

@greg0ire greg0ire deleted the greg0ire:deprecation-messages branch May 6, 2019

@greg0ire

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.