Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] improve doc again #11650

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Jun 3, 2019

Fixes all todos and more :)

fixes #11530.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 3, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc++ branch from a6e4210 to b64f67c Jun 3, 2019

@javiereguiluz
Copy link
Member

left a comment

Very nice 👏 I left some minor comments. Thanks!

Show resolved Hide resolved components/http_client.rst Outdated
Show resolved Hide resolved components/http_client.rst Outdated
Show resolved Hide resolved components/http_client.rst Outdated
Show resolved Hide resolved components/http_client.rst Outdated

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc++ branch from b64f67c to 100d6c4 Jun 3, 2019

@wouterj

wouterj approved these changes Jun 3, 2019

Show resolved Hide resolved components/http_client.rst Outdated
Show resolved Hide resolved components/http_client.rst Outdated
Show resolved Hide resolved components/http_client.rst Outdated

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc++ branch from 100d6c4 to f9339a3 Jun 3, 2019

@andreia
Copy link
Contributor

left a comment

Thanks a lot for documenting this :)
( I just made some tweaks to the cheat sheet also based on your update, thank you! :) )

Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst
Show resolved Hide resolved components/http_client.rst

@javiereguiluz javiereguiluz merged commit f9339a3 into symfony:4.3 Jun 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details

javiereguiluz added a commit that referenced this pull request Jun 4, 2019

minor #11650 [HttpClient] improve doc again (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] improve doc again

Fixes all todos and more :)

fixes #11530.

Commits
-------

f9339a3 [HttpClient] improve doc again
@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Nicolas, thanks a lot for contributing these improvements. Thanks to reviewers too, specially Andréia ... I fixed all the typos you reported while merging. Thanks!

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc++ branch Jun 4, 2019

@andreia

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Thank you Javier! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.