[cookbook][form][data_transformer] some formatting tweaks #1200

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

brikou commented Mar 28, 2012

No description provided.

@stof stof commented on an outdated diff Mar 28, 2012

cookbook/form/data_transformers.rst
namespace Acme\TaskBundle\Form\Type;
- use Symfony\Component\Form\AbstractType;
- use Symfony\Component\Form\FormBuilder;
- use Acme\TaskBundle\Form\DataTransformer\IssueToNumberTransformer;
- use Doctrine\Common\Persistence\ObjectManager;
+ use
+ Symfony\Component\Form\AbstractType,
+ Symfony\Component\Form\FormBuilder,
+ Acme\TaskBundle\Form\DataTransformer\IssueToNumberTransformer,
+ Doctrine\Common\Persistence\ObjectManager
@stof

stof Mar 28, 2012

Member

this does not follow the Symfony2 CS. We use a use statement per class.

Member

weaverryan commented Apr 11, 2012

Hi!

This looks good, but can you please re-make the pull request against the 2.0 branch? This isn't patching correctly, so the PR needs to be re-made.

Thanks!

@brikou brikou added a commit to brikou/symfony-docs that referenced this pull request Apr 11, 2012

@brikou brikou data_transformers (new clean PR related to #1200) 9d2b82a
Contributor

brikou commented Apr 11, 2012

@weaverryan Hi Ryan, I've just open a cleaner PR see #1238, cheer

brikou closed this Apr 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment