Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom logging formatter #12100

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@jjanvier
Copy link
Contributor

commented Aug 5, 2019

When I use the '@' in the service name, I get this kind of error:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 31:
                                                                                                                          
  The service "monolog.handler.deprecation" has a dependency on a non-existent service "@monolog.formatter.deprecation". 
@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

friendly ping @lyrixx

@OskarStark OskarStark added this to the 3.4 milestone Aug 6, 2019

@lyrixx

lyrixx approved these changes Aug 6, 2019

@lyrixx

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

👍

@OskarStark OskarStark added the Logger label Aug 6, 2019

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Thank you Julien for taking care of this regression.

@OskarStark OskarStark merged commit b3828cd into symfony:3.4 Aug 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details

OskarStark added a commit that referenced this pull request Aug 6, 2019

bug #12100 Fix custom logging formatter (jjanvier)
This PR was merged into the 3.4 branch.

Discussion
----------

Fix custom logging formatter

When I use the '@' in the service name, I get this kind of error:

```
In CheckExceptionOnInvalidReferenceBehaviorPass.php line 31:

  The service "monolog.handler.deprecation" has a dependency on a non-existent service "@monolog.formatter.deprecation".
```

Commits
-------

b3828cd Fix custom logging formatter

@jjanvier jjanvier deleted the jjanvier:patch-1 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.