Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on NamedAddress::fromString #12128

Open
wants to merge 5 commits into
base: 4.4
from

Conversation

@gisostallenberg
Copy link

commented Aug 9, 2019

@OskarStark
Copy link
Contributor

left a comment

Nice addition, can you please apply my suggestions?

Show resolved Hide resolved mailer.rst Outdated
Show resolved Hide resolved mailer.rst
Show resolved Hide resolved mailer.rst Outdated
Show resolved Hide resolved mailer.rst Outdated
Update mailer.rst
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>

gisostallenberg and others added some commits Aug 9, 2019

Update mailer.rst
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
Update mailer.rst
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
Update mailer.rst
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
@gisostallenberg

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Nice addition, can you please apply my suggestions?

Sure, done


$email = (new Email())
->from(NamedAddress::fromString('Fabien <fabien@example.com>'))
// ...

This comment has been minimized.

Copy link
@OskarStark

OskarStark Aug 9, 2019

Contributor
Suggested change
// ...
// ...

This comment has been minimized.

Copy link
@OskarStark

OskarStark Aug 9, 2019

Contributor

just one minor comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.